Commit ac8bee71 authored by Michael Lippautz's avatar Michael Lippautz Committed by Chromium LUCI CQ

Avoid deprecated v8::EmbedderHeapTracer enum

Use kNoHeapPointers instead of kEmpty.

Bug: 1056170
Change-Id: Ic45d8a216cda3a5ff30d3fe4bfdf32b08e806c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587732
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836578}
parent 01488c20
...@@ -89,7 +89,7 @@ void GCController::AsyncCollectAllWithEmptyStack( ...@@ -89,7 +89,7 @@ void GCController::AsyncCollectAllWithEmptyStack(
for (int i = 0; i < kNumberOfGCsForFullCollection; i++) { for (int i = 0; i < kNumberOfGCsForFullCollection; i++) {
isolate->GetEmbedderHeapTracer()->GarbageCollectionForTesting( isolate->GetEmbedderHeapTracer()->GarbageCollectionForTesting(
v8::EmbedderHeapTracer::EmbedderStackState::kEmpty); v8::EmbedderHeapTracer::EmbedderStackState::kNoHeapPointers);
} }
v8::HandleScope scope(isolate); v8::HandleScope scope(isolate);
......
...@@ -77,10 +77,12 @@ class BindingTestSupportingGC : public testing::Test { ...@@ -77,10 +77,12 @@ class BindingTestSupportingGC : public testing::Test {
v8::Isolate::GarbageCollectionType::kMinorGarbageCollection); v8::Isolate::GarbageCollectionType::kMinorGarbageCollection);
} }
void RunV8FullGC(v8::EmbedderHeapTracer::EmbedderStackState stack_state = void RunV8FullGC(
v8::EmbedderHeapTracer::EmbedderStackState::kEmpty) { v8::EmbedderHeapTracer::EmbedderStackState stack_state =
v8::EmbedderHeapTracer::EmbedderStackState::kNoHeapPointers) {
ThreadState::Current()->CollectAllGarbageForTesting( ThreadState::Current()->CollectAllGarbageForTesting(
stack_state == v8::EmbedderHeapTracer::EmbedderStackState::kEmpty stack_state ==
v8::EmbedderHeapTracer::EmbedderStackState::kNoHeapPointers
? BlinkGC::kNoHeapPointersOnStack ? BlinkGC::kNoHeapPointersOnStack
: BlinkGC::kHeapPointersOnStack); : BlinkGC::kHeapPointersOnStack);
} }
......
...@@ -22,7 +22,8 @@ namespace { ...@@ -22,7 +22,8 @@ namespace {
constexpr BlinkGC::StackState ToBlinkGCStackState( constexpr BlinkGC::StackState ToBlinkGCStackState(
v8::EmbedderHeapTracer::EmbedderStackState stack_state) { v8::EmbedderHeapTracer::EmbedderStackState stack_state) {
return stack_state == v8::EmbedderHeapTracer::EmbedderStackState::kEmpty return stack_state ==
v8::EmbedderHeapTracer::EmbedderStackState::kNoHeapPointers
? BlinkGC::kNoHeapPointersOnStack ? BlinkGC::kNoHeapPointersOnStack
: BlinkGC::kHeapPointersOnStack; : BlinkGC::kHeapPointersOnStack;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment