Commit ac92eda2 authored by Olivier Yiptong's avatar Olivier Yiptong Committed by Commit Bot

FontAccess: Make DidRequestPermission platform delegation more readable

Minor refactor: DidRequestPermission is rendered more readable with an
early exit in case there is no implementation.

Change-Id: Icd06cd9e18162a3363138d830fe8e01e41c32a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450839
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: default avatarJoshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814376}
parent 1bda04ec
......@@ -101,6 +101,11 @@ void FontAccessManagerImpl::EnumerateLocalFonts(
void FontAccessManagerImpl::DidRequestPermission(
EnumerateLocalFontsCallback callback,
blink::mojom::PermissionStatus status) {
#if !defined(PLATFORM_HAS_LOCAL_FONT_ENUMERATION_IMPL)
std::move(callback).Run(blink::mojom::FontEnumerationStatus::kUnimplemented,
base::ReadOnlySharedMemoryRegion());
return;
#else
if (status != blink::mojom::PermissionStatus::GRANTED) {
std::move(callback).Run(
blink::mojom::FontEnumerationStatus::kPermissionDenied,
......@@ -110,7 +115,6 @@ void FontAccessManagerImpl::DidRequestPermission(
// Per-platform delegation for obtaining cached font enumeration data occurs
// here, after the permission has been granted.
#if defined(PLATFORM_HAS_LOCAL_FONT_ENUMERATION_IMPL)
ipc_task_runner_->PostTask(
FROM_HERE, base::BindOnce(
[](EnumerateLocalFontsCallback callback,
......@@ -120,9 +124,6 @@ void FontAccessManagerImpl::DidRequestPermission(
results_task_runner, std::move(callback));
},
std::move(callback), results_task_runner_));
#else
std::move(callback).Run(blink::mojom::FontEnumerationStatus::kUnimplemented,
base::ReadOnlySharedMemoryRegion());
#endif
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment