Revert 285446 "Log the certificate subjects from the server cert..."

Tests failed on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32148

> Log the certificate subjects from the server certificate sent via QUIC.
> 
> Review URL: https://codereview.chromium.org/418723002

TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/415333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285480 0039d316-1c4b-4281-b951-d872f2087c98
parent ddaaf850
...@@ -1351,12 +1351,6 @@ EVENT_TYPE(QUIC_SESSION) ...@@ -1351,12 +1351,6 @@ EVENT_TYPE(QUIC_SESSION)
// } // }
EVENT_TYPE(QUIC_SESSION_CLOSE_ON_ERROR) EVENT_TYPE(QUIC_SESSION_CLOSE_ON_ERROR)
// Session verified a certificate from the server.
// {
// "subjects": <list of DNS names that the certificate is valid for>,
// }
EVENT_TYPE(QUIC_SESSION_CERTIFICATE_VERIFIED)
// Session received a QUIC packet. // Session received a QUIC packet.
// { // {
// "peer_address": <The ip:port of the peer>, // "peer_address": <The ip:port of the peer>,
......
...@@ -668,7 +668,6 @@ void QuicClientSession::OnProofVerifyDetailsAvailable( ...@@ -668,7 +668,6 @@ void QuicClientSession::OnProofVerifyDetailsAvailable(
CertVerifyResult* result_copy = new CertVerifyResult; CertVerifyResult* result_copy = new CertVerifyResult;
result_copy->CopyFrom(*cert_verify_result_other); result_copy->CopyFrom(*cert_verify_result_other);
cert_verify_result_.reset(result_copy); cert_verify_result_.reset(result_copy);
logger_.OnCertificateVerified(*cert_verify_result_);
} }
void QuicClientSession::StartReading() { void QuicClientSession::StartReading() {
......
...@@ -15,8 +15,6 @@ ...@@ -15,8 +15,6 @@
#include "base/values.h" #include "base/values.h"
#include "net/base/net_log.h" #include "net/base/net_log.h"
#include "net/base/net_util.h" #include "net/base/net_util.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/x509_certificate.h"
#include "net/quic/crypto/crypto_handshake_message.h" #include "net/quic/crypto/crypto_handshake_message.h"
#include "net/quic/crypto/crypto_protocol.h" #include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/quic_address_mismatch.h" #include "net/quic/quic_address_mismatch.h"
...@@ -241,23 +239,6 @@ base::Value* NetLogQuicOnConnectionClosedCallback( ...@@ -241,23 +239,6 @@ base::Value* NetLogQuicOnConnectionClosedCallback(
return dict; return dict;
} }
base::Value* NetLogQuicCertificateVerifiedCallback(
scoped_refptr<X509Certificate> cert,
NetLog::LogLevel /* log_level */) {
// Only the subjects are logged so that we can investigate connection pooling.
// More fields could be logged in the future.
std::vector<std::string> dns_names;
cert->GetDNSNames(&dns_names);
base::DictionaryValue* dict = new base::DictionaryValue();
base::ListValue* subjects = new base::ListValue();
for (std::vector<std::string>::const_iterator it = dns_names.begin();
it != dns_names.end(); it++) {
subjects->Append(new base::StringValue(*it));
}
dict->Set("subjects", subjects);
return dict;
}
void UpdatePacketGapSentHistogram(size_t num_consecutive_missing_packets) { void UpdatePacketGapSentHistogram(size_t num_consecutive_missing_packets) {
UMA_HISTOGRAM_COUNTS("Net.QuicSession.PacketGapSent", UMA_HISTOGRAM_COUNTS("Net.QuicSession.PacketGapSent",
num_consecutive_missing_packets); num_consecutive_missing_packets);
...@@ -691,13 +672,6 @@ void QuicConnectionLogger::UpdateReceivedFrameCounts( ...@@ -691,13 +672,6 @@ void QuicConnectionLogger::UpdateReceivedFrameCounts(
} }
} }
void QuicConnectionLogger::OnCertificateVerified(
const CertVerifyResult& result) {
net_log_.AddEvent(
NetLog::TYPE_QUIC_SESSION_CERTIFICATE_VERIFIED,
base::Bind(&NetLogQuicCertificateVerifiedCallback, result.verified_cert));
}
base::HistogramBase* QuicConnectionLogger::GetPacketSequenceNumberHistogram( base::HistogramBase* QuicConnectionLogger::GetPacketSequenceNumberHistogram(
const char* statistic_name) const { const char* statistic_name) const {
string prefix("Net.QuicSession.PacketReceived_"); string prefix("Net.QuicSession.PacketReceived_");
......
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
namespace net { namespace net {
class CryptoHandshakeMessage; class CryptoHandshakeMessage;
class CertVerifyResult;
// This class is a debug visitor of a QuicConnection which logs // This class is a debug visitor of a QuicConnection which logs
// events to |net_log|. // events to |net_log|.
...@@ -72,7 +71,6 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger ...@@ -72,7 +71,6 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
void UpdateReceivedFrameCounts(QuicStreamId stream_id, void UpdateReceivedFrameCounts(QuicStreamId stream_id,
int num_frames_received, int num_frames_received,
int num_duplicate_frames_received); int num_duplicate_frames_received);
void OnCertificateVerified(const CertVerifyResult& result);
private: private:
// Do a factory get for a histogram for recording data, about individual // Do a factory get for a histogram for recording data, about individual
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment