[Mac] Feature Flag for the Fullscreen Toolbar Reveal Animation

Create a feature flag for this feature.

Bug: 751784
Change-Id: I49ba9af40f68496b1e59f3e5f9fc5e0fa068ae6f
Reviewed-on: https://chromium-review.googlesource.com/598628Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491746}

chrome/browser/about_flags.cc

@@ -2589,7 +2589,7 @@ const FeatureEntry kFeatureEntries[] = {
     {"enable-fullscreen-toolbar-reveal",
      flag_descriptions::kFullscreenToolbarRevealName,
      flag_descriptions::kFullscreenToolbarRevealDescription, kOsMac,
-     SINGLE_VALUE_TYPE(switches::kEnableFullscreenToolbarReveal)},
+     FEATURE_VALUE_TYPE(features::kFullscreenToolbarReveal)},
 #endif  // OS_MACOSX
     {"important-sites-in-cbd", flag_descriptions::kImportantSitesInCbdName,
      flag_descriptions::kImportantSitesInCbdDescription, kOsAll,

chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm

@@ -5,6 +5,7 @@
 #import "chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h"
 
 #include "base/command_line.h"
+#include "base/feature_list.h"
 #include "chrome/browser/profiles/profile.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.h"
@@ -12,6 +13,7 @@
 #import "chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h"
 #import "chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_visibility_lock_controller.h"
 #import "chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.h"
+#include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 
@@ -84,10 +86,8 @@ const CGFloat kShowFraction = 1.0;
 
 - (void)revealToolbarForWebContents:(content::WebContents*)contents
                        inForeground:(BOOL)inForeground {
-  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableFullscreenToolbarReveal)) {
+  if (!base::FeatureList::IsEnabled(features::kFullscreenToolbarReveal))
     return;
-  }
 
   animationController_->AnimateToolbarForTabstripChanges(contents,
                                                          inForeground);

chrome/common/chrome_features.cc

@@ -25,6 +25,10 @@ const base::Feature kAllowAutoplayUnmutedInWebappManifestScope{
 const base::Feature kAppleScriptExecuteJavaScript{
     "AppleScriptExecuteJavaScript", base::FEATURE_ENABLED_BY_DEFAULT};
 
+// Enables the fullscreen toolbar to reveal itself if it's hidden.
+const base::Feature kFullscreenToolbarReveal{"FullscreenToolbarReveal",
+                                             base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Use the Toolkit-Views Task Manager window.
 const base::Feature kViewsTaskManager{"ViewsTaskManager",
                                       base::FEATURE_DISABLED_BY_DEFAULT};

chrome/common/chrome_features.h

@@ -96,6 +96,10 @@ extern const base::Feature kExpectCTReporting;
 extern const base::Feature kExperimentalAppBanners;
 extern const base::Feature kExperimentalKeyboardLockUI;
 
+#if defined(OS_MACOSX)
+extern const base::Feature kFullscreenToolbarReveal;
+#endif
+
 #if defined(OS_WIN)
 extern const base::Feature kGdiTextPrinting;
 #endif

tools/metrics/histograms/enums.xml

@@ -22797,6 +22797,7 @@ uploading your change for review.  These are checked by presubmit scripts.
   <int value="-1604051051" label="SpecialLocale:disabled"/>
   <int value="-1599538279" label="enable-md-policy-page"/>
   <int value="-1596559650" label="max-tiles-for-interest-area"/>
+  <int value="-1594298767" label="FullscreenToolbarReveal:enabled"/>
   <int value="-1586642651" label="MaterialDesignExtensions:disabled"/>
   <int value="-1583728573" label="AutofillCreditCardSigninPromo:disabled"/>
   <int value="-1581724231" label="ModalPermissionPrompts:enabled"/>
@@ -23864,6 +23865,7 @@ from previous Chrome versions.
   <int value="1910240042" label="enable-experimental-fullscreen-exit-ui"/>
   <int value="1913298816" label="OverlayScrollbar:enabled"/>
   <int value="1915178511" label="disable-blink-features"/>
+  <int value="1925627218" label="FullscreenToolbarReveal:disabled"/>
   <int value="1927259098" label="TranslateLanguageByULP:enabled"/>
   <int value="1928407249" label="NewPhotoPicker:enabled"/>
   <int value="1930901873" label="disable-sync-app-list"/>