Skip to content

GitLab

T
tangled
Commit acc21fc8 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot
Browse files
Options

[CompositeAfterPaint] Update web test expectations 

Rebaseline some tests for CAP.

compositing/change-preferCompositingToLCDText-setting.html is removed
because we don't (need to) support dynamic switching setting of
prefer-compositing-to-lcd-text. The related compositing decision
functionality has been tested in unit tests.

Bug: 524134
Change-Id: I5b63d582b012f60914d961444393871921596ff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925770Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717258}
parent d33c79e4
Hide whitespace changes
Inline Side-by-side
Showing with 340 additions and 90 deletions
third_party/blink/web_tests/FlagExpectations/composite-after-paint
View file @ acc21fc8
......@@ -35,6 +35,15 @@ crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrol
crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrollbar-over-child-layer-nested-2.html [ Pass ]
crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrollbar-over-child-layer-nested.html [ Pass ]
# Missing composited layers for elements without visible contents.
crbug.com/937573 compositing/geometry/foreground-layer.html [ Failure ]
crbug.com/937573 compositing/geometry/limit-layer-bounds-opacity-transition.html [ Failure ]
crbug.com/937573 compositing/geometry/limit-layer-bounds-overflow-root.html [ Failure ]
crbug.com/937573 compositing/geometry/limit-layer-bounds-positioned-transition.html [ Failure ]
crbug.com/937573 compositing/geometry/limit-layer-bounds-positioned.html [ Failure ]
crbug.com/937573 compositing/geometry/limit-layer-bounds-transformed.html [ Failure ]
crbug.com/937573 compositing/layer-creation/scroll-partial-update.html [ Failure ]
Bug(none) virtual/android/fullscreen/video-overlay-scroll.html [ Failure ]
Bug(none) virtual/android/rootscroller/fixed-chaining-with-implicit-pointer-events-none.html [ Failure ]
Bug(none) virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html [ Crash ]
......@@ -46,34 +55,26 @@ crbug.com/1008501 compositing/culling/filter-occlusion-blur-large.html [ Failure
crbug.com/1008501 compositing/culling/filter-occlusion-blur.html [ Failure ]
crbug.com/1008501 compositing/reflections/deeply-nested-reflections.html [ Failure ]
# Missing compositing reasons.
Bug(none) compositing/animation/hidden-composited.html [ Failure ]
Bug(none) compositing/change-preferCompositingToLCDText-setting.html [ Failure ]
# Wrong contentsOpaque or background color.
Bug(none) compositing/contents-opaque/control-layer.html [ Failure ]
Bug(none) compositing/contents-opaque/hidden-with-visible-child.html [ Failure ]
Bug(none) compositing/contents-opaque/layer-opacity.html [ Failure ]
Bug(none) compositing/draws-content/canvas-background-layer.html [ Failure ]
Bug(none) compositing/draws-content/webgl-background-layer.html [ Failure ]
Bug(none) compositing/geometry/bounds-clipped-composited-child.html [ Failure ]
Bug(none) compositing/geometry/bounds-ignores-hidden.html [ Failure ]
Bug(none) compositing/geometry/foreground-layer.html [ Failure ]
Bug(none) compositing/geometry/limit-layer-bounds-opacity-transition.html [ Failure ]
Bug(none) compositing/geometry/limit-layer-bounds-overflow-root.html [ Failure ]
Bug(none) compositing/geometry/limit-layer-bounds-positioned-transition.html [ Failure ]
Bug(none) compositing/geometry/limit-layer-bounds-positioned.html [ Failure ]
Bug(none) compositing/geometry/limit-layer-bounds-transformed.html [ Failure ]
# Flaky result of contentsOpqaue.
Bug(none) paint/invalidation/window-resize/window-resize-child-background-image-fixed-centered.html [ Pass Failure ]
# Needs to implement logic for CompositingReasons::kAssumedOverlap.
Bug(none) compositing/layer-creation/overlap-animation-clipping.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-animation-container.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-animation.html [ Failure ]
# Overlap testing seems inaccurate.
Bug(none) compositing/layer-creation/overlap-transformed-3d.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-transformed-and-clipped.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-transformed-layer-with-transform-body.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-transformed-layer.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-transformed-preserved-3d.html [ Failure ]
Bug(none) compositing/layer-creation/overlap-transforms.html [ Failure ]
Bug(none) compositing/layer-creation/scroll-partial-update.html [ Failure ]
Bug(none) compositing/masks/mask-with-removed-filters.html [ Failure ]
crbug.com/979367 compositing/overflow/overflow-scroll-background-fractional-offset.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-content-fractional-offset.html [ Failure ]
crbug.com/667946 compositing/overflow/scrolls-with-respect-to-nested.html [ Failure ]
crbug.com/667946 compositing/overflow/scrolls-with-respect-to-transform.html [ Failure ]
crbug.com/667946 compositing/overflow/scrolls-with-respect-to.html [ Failure ]
......@@ -139,7 +140,6 @@ Bug(none) paint/invalidation/compositing/should-not-repaint-composited-opacity.h
Bug(none) paint/invalidation/compositing/should-not-repaint-move-backface-hidden.html [ Failure ]
Bug(none) paint/invalidation/scroll/iframe-scroll-repaint.html [ Failure ]
Bug(none) paint/invalidation/scroll/repaint-composited-child-in-scrolled-container.html [ Failure ]
Bug(none) paint/invalidation/position/layout-state-only-positioned.html [ Failure ]
Bug(none) paint/invalidation/position/relative-positioned-movement-repaint.html [ Failure ]
# Extra layer for fixed-position.
......@@ -151,6 +151,10 @@ Bug(none) paint/invalidation/scroll/fixed-under-composited-fixed-scrolled.html [
Bug(none) paint/invalidation/scroll/scroll-in-fixed-layer.html [ Failure ]
# Other extra layers.
Bug(none) compositing/geometry/bounds-clipped-composited-child.html [ Failure ]
Bug(none) compositing/geometry/bounds-ignores-hidden.html [ Failure ]
Bug(none) compositing/rtl/rtl-absolute-overflow-scrolled.html [ Failure ]
Bug(none) compositing/rtl/rtl-fixed-overflow-scrolled.html [ Failure ]
Bug(none) paint/invalidation/filters/filter-on-html-element-with-fixed-position-child.html [ Failure ]
Bug(none) paint/invalidation/scroll/invalidate-caret-in-composited-scrolling-container.html [ Failure ]
Bug(none) paint/invalidation/scroll/invalidate-caret-in-non-composited-scrolling-container.html [ Failure ]
......@@ -170,20 +174,16 @@ Bug(none) paint/invalidation/compositing/iframe-inside-squashed-layer.html [ Fai
Bug(none) paint/invalidation/compositing/overlap-test-with-filter.html [ Failure ]
Bug(none) paint/invalidation/compositing/should-not-repaint-composited-descendants.html [ Failure ]
# Subpixel or 1-pixel differences. May be real subpixel handling bugs.
Bug(none) paint/invalidation/scroll/scroll-in-transformed-layer.html [ Failure ]
Bug(none) paint/invalidation/scroll/scroll-with-transformed-parent-layer.html [ Failure ]
Bug(none) external/wpt/svg/render/reftests/blending-001.svg [ Failure ]
Bug(none) external/wpt/svg/render/reftests/blending-002.svg [ Failure ]
# Invisible subpixel or invisible color differences that look benign, but we can't rebaseline ref tests.
Bug(none) compositing/overflow/ancestor-with-clip-path.html [ Failure ]
Bug(none) fast/multicol/mixed-opacity-fixed-test.html [ Failure ]
Bug(none) fast/multicol/mixed-positioning-stacking-order.html [ Failure ]
Bug(none) fullscreen/rendering/backdrop-object.html [ Failure ]
Bug(none) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-003.html [ Failure ]
Bug(none) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004.html [ Failure ]
Bug(none) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-005.html [ Failure ]
# Subpixel or invisible color differences that look benign, but we can't rebaseline ref tests.
Bug(benign) compositing/overflow/ancestor-with-clip-path.html [ Failure ]
Bug(benign) fast/multicol/mixed-opacity-fixed-test.html [ Failure ]
Bug(benign) fast/multicol/mixed-positioning-stacking-order.html [ Failure ]
Bug(benign) fullscreen/rendering/backdrop-object.html [ Failure ]
Bug(benign) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-003.html [ Failure ]
Bug(benign) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004.html [ Failure ]
Bug(benign) external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-005.html [ Failure ]
Bug(benign) external/wpt/svg/render/reftests/blending-001.svg [ Failure ]
Bug(benign) external/wpt/svg/render/reftests/blending-002.svg [ Failure ]
# Text failures due to layerization differences
Bug(none) compositing/overflow/scroller-with-border-radius.html [ Failure ]
......@@ -201,7 +201,6 @@ crbug.com/931486 compositing/squashing/squash-above-fixed-1.html [ Failure ]
crbug.com/931486 compositing/squashing/squash-above-fixed-3.html [ Failure ]
crbug.com/931486 paint/invalidation/compositing/pointer-events-composited-scrolling.html [ Failure ]
crbug.com/931486 paint/invalidation/compositing/scrolling-neg-z-index-descendants.html [ Failure ]
crbug.com/931486 paint/invalidation/flexbox/scrollbars-changed.html [ Failure ]
crbug.com/931486 paint/invalidation/scroll/composited-iframe-scroll-repaint.html [ Failure ]
crbug.com/931486 paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint.html [ Failure ]
crbug.com/931486 scrollbars/overlay-scrollbars-within-overflow-scroll.html [ Failure ]
......@@ -244,9 +243,9 @@ Bug(none) http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ]
# Missing WheelEventHandler
Bug(none) http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
# Scrollbar snapping issues
crbug.com/979380 compositing/rtl/rtl-absolute-overflow-scrolled.html [ Failure ]
crbug.com/979380 compositing/rtl/rtl-fixed-overflow-scrolled.html [ Failure ]
# Scrollbar pixel snapping issues
crbug.com/979380 compositing/overflow/overflow-scroll-background-fractional-offset.html [ Failure ]
crbug.com/979380 compositing/overflow/overflow-scroll-content-fractional-offset.html [ Failure ]
crbug.com/979380 compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ Failure ]
crbug.com/979380 compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure ]
crbug.com/979380 fast/frames/transparent-scrollbar.html [ Failure ]
......
third_party/blink/web_tests/compositing/change-preferCompositingToLCDText-setting.html deleted 100644 → 0
View file @ d33c79e4
<!DOCTYPE HTML>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<style>
#scroller {
overflow: scroll;
height: 300px;
width: 300px;
background-color: rgba(255,0,0,0.5); /* Force non-promotion due to background opacity */;
}
#scrolled {
height: 1000px;
width: 250px;
background-color: rgba(0,128,0,0.5); /* Force non-promotion due to background opacity */;
}
</style>
<script>
var t = async_test("Check that the preferCompositingToLCDText flag results in compositing");
function isUsingCompositedScrolling() {
var layers = JSON.parse(internals.layerTreeAsText(document));
var found = false;
layers["layers"].forEach(function(layer) {
if (layer.bounds[1] == 1000)
found = true;
});
return found;
}
window.onload = function() {
t.step(function() {
assert_not_equals(window.internals, null, 'This test requires window.internals');
internals.settings.setPreferCompositingToLCDTextEnabled(false);
var stateBefore = isUsingCompositedScrolling();
internals.settings.setPreferCompositingToLCDTextEnabled(true);
var stateAfter = isUsingCompositedScrolling();
assert_false(stateBefore, 'Composited scrolling began disabled');
assert_true(stateAfter, 'Composited scrolling became enabled');
t.done();
});
};
</script>
<div id="scroller">
<div id="scrolled"></div>
</div>
third_party/blink/web_tests/compositing/contents-opaque/hidden-with-visible-child.html
View file @ acc21fc8
......@@ -3,12 +3,12 @@
<head>
<style>
#caption {
width: 200px;
height: 100px;
background-color: green;
will-change: transform;
}
.inner {
width: 200px;
height: 100px;
visibility: visible;
background-color: blue;
}
......
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/contents-opaque/hidden-with-visible-child-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutNGBlockFlow (positioned) DIV id='caption'",
"bounds": [200, 100],
"contentsOpaque": true,
"backgroundColor": "#0000FF",
"transform": 1
}
],
"transforms": [
{
"id": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[8, 13, 0, 1]
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/draws-content/canvas-background-layer-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-simple'",
"position": [13, 8],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-transparent-background'",
"position": [13, 73],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-padding'",
"position": [18, 143],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-border'",
"position": [18, 208],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-image'",
"position": [13, 268],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-opaque'",
"position": [13, 333],
"bounds": [50, 50],
"contentsOpaque": true
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-opaque-border'",
"position": [18, 403],
"bounds": [50, 50],
"contentsOpaque": true
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-opaque-box-shadow'",
"position": [13, 463],
"bounds": [50, 50],
"contentsOpaque": true
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/draws-content/webgl-background-layer-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-simple'",
"position": [13, 8],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-padding'",
"position": [18, 78],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-border'",
"position": [18, 143],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-image'",
"position": [13, 203],
"bounds": [50, 50]
},
{
"name": "LayoutHTMLCanvas CANVAS id='canvas-transparent-background'",
"position": [13, 268],
"bounds": [50, 50]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutNGBlockFlow (positioned) DIV class='under composited'",
"bounds": [100, 100],
"contentsOpaque": true,
"backgroundColor": "#FF0000",
"transform": 1
},
{
"name": "LayoutNGBlockFlow (positioned) DIV class='over'",
"bounds": [100, 100],
"contentsOpaque": true,
"backgroundColor": "#008000",
"transform": 1
}
],
"transforms": [
{
"id": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[110, 0, 0, 1]
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/layer-creation/overlap-transformed-layer-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/compositing/layer-creation/overlap-transforms-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutNGBlockFlow (relative positioned) DIV class='transformed box'",
"bounds": [100, 100],
"contentsOpaque": true,
"backgroundColor": "#0000FF",
"transform": 2
}
],
"transforms": [
{
"id": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[19, 19, 0, 1]
]
},
{
"id": 2,
"parent": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[0, 0, 1, 1]
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/flexbox/scrollbars-changed-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "NGPhysicalTextFragment 'a'",
"rect": [0, 5, 15, 15],
"reason": "disappeared"
},
{
"object": "NGPhysicalTextFragment 'z'",
"rect": [0, 5, 15, 15],
"reason": "appeared"
}
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/position/layout-state-only-positioned-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutNGBlockFlow (positioned) DIV",
"rect": [0, 50, 106, 106],
"reason": "chunk appeared"
},
{
"object": "LayoutNGBlockFlow HTML",
"rect": [0, 50, 106, 106],
"reason": "chunk disappeared"
},
{
"object": "VerticalScrollbar",
"rect": [88, 53, 15, 100],
"reason": "chunk appeared"
}
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/scroll/scroll-in-transformed-layer-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 2016],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutNGBlockFlow (positioned) DIV class='absolute green'",
"rect": [79, 129, 142, 142],
"reason": "chunk appeared"
},
{
"object": "LayoutNGBlockFlow (positioned) DIV class='absolute red'",
"rect": [100, 150, 100, 100],
"reason": "chunk disappeared"
}
]
}
]
}
third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/scroll/scroll-with-transformed-parent-layer-expected.txt 0 → 100644
View file @ acc21fc8
{
"layers": [
{
"name": "Scrolling background of LayoutView #document",
"bounds": [800, 2016],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutNGBlockFlow (positioned) DIV class='absolute green'",
"rect": [79, 129, 142, 142],
"reason": "chunk appeared"
},
{
"object": "LayoutNGBlockFlow (positioned) DIV class='absolute red'",
"rect": [79, 129, 142, 142],
"reason": "chunk disappeared"
}
]
}
]
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment