Update name of strict-origin-when-cross-origin referrer policy

This changes updates all uses of
kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin
to kReferrerPolicyStrictOriginWhenCrossOrigin, to more closely
match the spec.

R=jochen@chromium.org, tkent@chromium.org

Change-Id: I04412fc56e0739e91783f1cc6d3c7d981d54b289
Reviewed-on: https://chromium-review.googlesource.com/952528Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544144}

third_party/WebKit/Source/core/dom/DocumentTest.cpp

@@ -508,7 +508,7 @@ TEST_F(DocumentTest, referrerPolicyParsing) {
       {"same-origin", kReferrerPolicySameOrigin, false},
       {"strict-origin", kReferrerPolicyStrictOrigin, false},
       {"strict-origin-when-cross-origin",
-       kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin, false},
+       kReferrerPolicyStrictOriginWhenCrossOrigin, false},
       {"unsafe-url", kReferrerPolicyAlways},
   };
 

third_party/WebKit/Source/core/fetch/Request.cpp

@@ -637,7 +637,7 @@ String Request::getReferrerPolicy() const {
       return "same-origin";
     case kReferrerPolicyStrictOrigin:
       return "strict-origin";
-    case kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin:
+    case kReferrerPolicyStrictOriginWhenCrossOrigin:
       return "strict-origin-when-cross-origin";
   }
   NOTREACHED();

third_party/WebKit/Source/core/fetch/RequestInit.cpp

@@ -235,8 +235,7 @@ void RequestInit::CheckEnumValues(
     } else if (*referrer_policy_string == "unsafe-url") {
       referrer_.referrer_policy = kReferrerPolicyAlways;
     } else if (*referrer_policy_string == "strict-origin-when-cross-origin") {
-      referrer_.referrer_policy =
-          kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin;
+      referrer_.referrer_policy = kReferrerPolicyStrictOriginWhenCrossOrigin;
     } else {
       exception_state.ThrowTypeError("Invalid referrer policy");
       return;

third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

@@ -830,7 +830,7 @@ TEST_F(HTMLPreloadScannerTest, testReferrerPolicy) {
        "referrerpolicy='strict-origin-when-cross-origin' "
        "href='bla.gif'/>",
        "bla.gif", "http://example.test/", Resource::kImage, 0,
-       kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin, nullptr},
+       kReferrerPolicyStrictOriginWhenCrossOrigin, nullptr},
       {"http://example.test",
        "<link rel='stylesheet' href='sheet.css' type='text/css'>", "sheet.css",
        "http://example.test/", Resource::kCSSStyleSheet, 0,

third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -399,7 +399,7 @@ String GetReferrerPolicy(ReferrerPolicy policy) {
       return protocol::Network::Request::ReferrerPolicyEnum::SameOrigin;
     case kReferrerPolicyStrictOrigin:
       return protocol::Network::Request::ReferrerPolicyEnum::StrictOrigin;
-    case kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin:
+    case kReferrerPolicyStrictOriginWhenCrossOrigin:
       return protocol::Network::Request::ReferrerPolicyEnum::
           StrictOriginWhenCrossOrigin;
   }

third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

@@ -315,7 +315,7 @@ constexpr ReferrerPolicy kPreloadReferrerPolicyTestParams[] = {
     kReferrerPolicyOriginWhenCrossOrigin,
     kReferrerPolicySameOrigin,
     kReferrerPolicyStrictOrigin,
-    kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
+    kReferrerPolicyStrictOriginWhenCrossOrigin,
     kReferrerPolicyNever};
 
 class LinkLoaderPreloadReferrerPolicyTest

third_party/WebKit/Source/platform/weborigin/ReferrerPolicy.h

@@ -50,9 +50,7 @@ enum ReferrerPolicy : uint8_t {
   // https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-strict-origin-when-cross-origin
   // Also used as the default policy when reduced-referrer-granularity is
   // enabled (not spec conformant).
-  // TODO(estark): rename to kReferrerPolicyStrictOriginWhenCrossOrigin to
-  // match spec.
-  kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
+  kReferrerPolicyStrictOriginWhenCrossOrigin,
   // https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-same-origin
   kReferrerPolicySameOrigin,
   // https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-strict-origin

third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp

@@ -86,8 +86,7 @@ Referrer SecurityPolicy::GenerateReferrer(ReferrerPolicy referrer_policy,
   ReferrerPolicy referrer_policy_no_default = referrer_policy;
   if (referrer_policy_no_default == kReferrerPolicyDefault) {
     if (RuntimeEnabledFeatures::ReducedReferrerGranularityEnabled()) {
-      referrer_policy_no_default =
-          kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin;
+      referrer_policy_no_default = kReferrerPolicyStrictOriginWhenCrossOrigin;
     } else {
       referrer_policy_no_default = kReferrerPolicyNoReferrerWhenDowngrade;
     }
@@ -143,7 +142,7 @@ Referrer SecurityPolicy::GenerateReferrer(ReferrerPolicy referrer_policy,
                           : origin + "/",
                       referrer_policy_no_default);
     }
-    case kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin: {
+    case kReferrerPolicyStrictOriginWhenCrossOrigin: {
       scoped_refptr<const SecurityOrigin> referrer_origin =
           SecurityOrigin::Create(referrer_url);
       scoped_refptr<const SecurityOrigin> url_origin =
@@ -316,7 +315,7 @@ bool SecurityPolicy::ReferrerPolicyFromString(
     return true;
   }
   if (EqualIgnoringASCIICase(policy, "strict-origin-when-cross-origin")) {
-    *result = kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin;
+    *result = kReferrerPolicyStrictOriginWhenCrossOrigin;
     return true;
   }
   if (EqualIgnoringASCIICase(policy, "no-referrer-when-downgrade") ||
@@ -381,6 +380,6 @@ STATIC_ASSERT_ENUM(kWebReferrerPolicySameOrigin, kReferrerPolicySameOrigin);
 STATIC_ASSERT_ENUM(kWebReferrerPolicyStrictOrigin, kReferrerPolicyStrictOrigin);
 STATIC_ASSERT_ENUM(
     kWebReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
-    kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin);
+    kReferrerPolicyStrictOriginWhenCrossOrigin);
 
 }  // namespace blink

third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp

@@ -105,8 +105,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
       {kReferrerPolicySameOrigin, kInsecureURLA, kInsecureURLA, kInsecureURLA},
       {kReferrerPolicyStrictOrigin, kInsecureURLA, kInsecureURLA,
        kInsecureOriginA},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
-       kInsecureURLA, kInsecureURLA, kInsecureURLA},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kInsecureURLA, kInsecureURLA,
+       kInsecureURLA},
 
       // HTTP -> HTTP: Cross Origin
       {kReferrerPolicyAlways, kInsecureURLA, kInsecureURLB, kInsecureURLA},
@@ -120,8 +120,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
       {kReferrerPolicySameOrigin, kInsecureURLA, kInsecureURLB, nullptr},
       {kReferrerPolicyStrictOrigin, kInsecureURLA, kInsecureURLB,
        kInsecureOriginA},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
-       kInsecureURLA, kInsecureURLB, kInsecureOriginA},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kInsecureURLA, kInsecureURLB,
+       kInsecureOriginA},
 
       // HTTPS -> HTTPS: Same Origin
       {kReferrerPolicyAlways, kSecureURLA, kSecureURLA, kSecureURLA},
@@ -134,8 +134,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
        kSecureURLA},
       {kReferrerPolicySameOrigin, kSecureURLA, kSecureURLA, kSecureURLA},
       {kReferrerPolicyStrictOrigin, kSecureURLA, kSecureURLA, kSecureOriginA},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin, kSecureURLA,
-       kSecureURLA, kSecureURLA},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kSecureURLA, kSecureURLA,
+       kSecureURLA},
 
       // HTTPS -> HTTPS: Cross Origin
       {kReferrerPolicyAlways, kSecureURLA, kSecureURLB, kSecureURLA},
@@ -148,8 +148,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
        kSecureOriginA},
       {kReferrerPolicySameOrigin, kSecureURLA, kSecureURLB, nullptr},
       {kReferrerPolicyStrictOrigin, kSecureURLA, kSecureURLB, kSecureOriginA},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin, kSecureURLA,
-       kSecureURLB, kSecureOriginA},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kSecureURLA, kSecureURLB,
+       kSecureOriginA},
 
       // HTTP -> HTTPS
       {kReferrerPolicyAlways, kInsecureURLA, kSecureURLB, kInsecureURLA},
@@ -163,8 +163,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
       {kReferrerPolicySameOrigin, kInsecureURLA, kSecureURLB, nullptr},
       {kReferrerPolicyStrictOrigin, kInsecureURLA, kSecureURLB,
        kInsecureOriginA},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin,
-       kInsecureURLA, kSecureURLB, kInsecureOriginA},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kInsecureURLA, kSecureURLB,
+       kInsecureOriginA},
 
       // HTTPS -> HTTP
       {kReferrerPolicyAlways, kSecureURLA, kInsecureURLB, kSecureURLA},
@@ -177,8 +177,8 @@ TEST(SecurityPolicyTest, GenerateReferrer) {
        kSecureOriginA},
       {kReferrerPolicySameOrigin, kSecureURLA, kInsecureURLB, nullptr},
       {kReferrerPolicyStrictOrigin, kSecureURLA, kInsecureURLB, nullptr},
-      {kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin, kSecureURLA,
-       kInsecureURLB, nullptr},
+      {kReferrerPolicyStrictOriginWhenCrossOrigin, kSecureURLA, kInsecureURLB,
+       nullptr},
 
       // blob and filesystem URL handling
       {kReferrerPolicyAlways, kInsecureURLA, kBlobURL, nullptr},