Commit ad0fa2f1 authored by Ionel Popescu's avatar Ionel Popescu Committed by Commit Bot

Avoid having uninitialized values for DateTimeChooserParameters fields.

When the date/time doesn't have "date-time-edit" in its shadow subtree,
the is_ampm_first, has_ampm, has_second, has_millisecond fields are going
to be uninitialized.

This CL ensures that the fields are always initialized.

Bug: 1026906
Change-Id: Ibfa8dd9993cf291402407e3592de82387c3d68b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927574Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#717703}
parent 002523c9
...@@ -324,6 +324,11 @@ bool MultipleFieldsTemporalInputTypeView::SetupDateTimeChooserParameters( ...@@ -324,6 +324,11 @@ bool MultipleFieldsTemporalInputTypeView::SetupDateTimeChooserParameters(
parameters.has_ampm = edit->HasField(DateTimeField::kAMPM); parameters.has_ampm = edit->HasField(DateTimeField::kAMPM);
parameters.has_second = edit->HasField(DateTimeField::kSecond); parameters.has_second = edit->HasField(DateTimeField::kSecond);
parameters.has_millisecond = edit->HasField(DateTimeField::kMillisecond); parameters.has_millisecond = edit->HasField(DateTimeField::kMillisecond);
} else {
parameters.is_ampm_first = false;
parameters.has_ampm = false;
parameters.has_second = false;
parameters.has_millisecond = false;
} }
return GetElement().SetupDateTimeChooserParameters(parameters); return GetElement().SetupDateTimeChooserParameters(parameters);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment