Commit ad144a2b authored by Xida Chen's avatar Xida Chen Committed by Chromium LUCI CQ

[Code health] Convert base::Bind in media_file_system_registry_unittest.cc

This CL converts base::Bind to base::BindOnce in this file. The
function is already expecting a OnceCallback so using BindOnce is
the right choice.

Bug: 1152278
Change-Id: I168b2049878b43cef21065a5bf6825ddfa64e68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593469Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837148}
parent 29f7ac0a
...@@ -513,29 +513,30 @@ void ProfileState::CheckGalleries( ...@@ -513,29 +513,30 @@ void ProfileState::CheckGalleries(
std::vector<base::string16> empty_names; std::vector<base::string16> empty_names;
registry->GetMediaFileSystemsForExtension( registry->GetMediaFileSystemsForExtension(
single_web_contents_.get(), no_permissions_extension_.get(), single_web_contents_.get(), no_permissions_extension_.get(),
base::Bind(&ProfileState::CompareResults, base::Unretained(this), base::BindOnce(&ProfileState::CompareResults, base::Unretained(this),
base::StringPrintf("%s (no permission)", test.c_str()), base::StringPrintf("%s (no permission)", test.c_str()),
std::cref(empty_names), std::cref(empty_expectation))); std::cref(empty_names), std::cref(empty_expectation)));
content::RunAllTasksUntilIdle(); content::RunAllTasksUntilIdle();
EXPECT_EQ(1, GetAndClearComparisonCount()); EXPECT_EQ(1, GetAndClearComparisonCount());
// Read permission only. // Read permission only.
registry->GetMediaFileSystemsForExtension( registry->GetMediaFileSystemsForExtension(
single_web_contents_.get(), regular_permission_extension_.get(), single_web_contents_.get(), regular_permission_extension_.get(),
base::Bind(&ProfileState::CompareResults, base::Unretained(this), base::BindOnce(
base::StringPrintf("%s (regular permission)", test.c_str()), &ProfileState::CompareResults, base::Unretained(this),
std::cref(compare_names_read_), base::StringPrintf("%s (regular permission)", test.c_str()),
std::cref(regular_extension_galleries))); std::cref(compare_names_read_),
std::cref(regular_extension_galleries)));
content::RunAllTasksUntilIdle(); content::RunAllTasksUntilIdle();
EXPECT_EQ(1, GetAndClearComparisonCount()); EXPECT_EQ(1, GetAndClearComparisonCount());
// All galleries permission. // All galleries permission.
registry->GetMediaFileSystemsForExtension( registry->GetMediaFileSystemsForExtension(
single_web_contents_.get(), all_permission_extension_.get(), single_web_contents_.get(), all_permission_extension_.get(),
base::Bind(&ProfileState::CompareResults, base::Unretained(this), base::BindOnce(&ProfileState::CompareResults, base::Unretained(this),
base::StringPrintf("%s (all permission)", test.c_str()), base::StringPrintf("%s (all permission)", test.c_str()),
std::cref(compare_names_all_), std::cref(compare_names_all_),
std::cref(all_extension_galleries))); std::cref(all_extension_galleries)));
content::RunAllTasksUntilIdle(); content::RunAllTasksUntilIdle();
EXPECT_EQ(1, GetAndClearComparisonCount()); EXPECT_EQ(1, GetAndClearComparisonCount());
} }
...@@ -546,7 +547,7 @@ FSInfoMap ProfileState::GetGalleriesInfo(extensions::Extension* extension) { ...@@ -546,7 +547,7 @@ FSInfoMap ProfileState::GetGalleriesInfo(extensions::Extension* extension) {
g_browser_process->media_file_system_registry(); g_browser_process->media_file_system_registry();
registry->GetMediaFileSystemsForExtension( registry->GetMediaFileSystemsForExtension(
single_web_contents_.get(), extension, single_web_contents_.get(), extension,
base::Bind(&GetGalleryInfoCallback, base::Unretained(&results))); base::BindOnce(&GetGalleryInfoCallback, base::Unretained(&results)));
content::RunAllTasksUntilIdle(); content::RunAllTasksUntilIdle();
return results; return results;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment