Commit ad35cc5d authored by Mike Wittman's avatar Mike Wittman Committed by Commit Bot

[Sampling profiler] Disable profiling on OS X 10.16

Disabling until we can make the profiler work on this version to avoid
crashes.

Bug: 1098119
Change-Id: I88194799e3e8d6635a055ca3ac4b38b8103b14b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261133Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781443}
parent 12ad2067
...@@ -227,6 +227,14 @@ StackSamplingConfiguration::GenerateConfiguration() { ...@@ -227,6 +227,14 @@ StackSamplingConfiguration::GenerateConfiguration() {
if (!IsProfilerSupportedForPlatformAndChannel()) if (!IsProfilerSupportedForPlatformAndChannel())
return PROFILE_DISABLED; return PROFILE_DISABLED;
#if defined(OS_MACOSX)
// TODO(https://crbug.com/1098119): Fix unwinding on OS X 10.16. The OS has
// moved all system libraries into the dyld shared cache and this seems to
// break the sampling profiler.
if (base::mac::IsOSLaterThan10_15_DontCallThis())
return PROFILE_DISABLED;
#endif
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
// Allow profiling if the Android Java/native unwinder module is available at // Allow profiling if the Android Java/native unwinder module is available at
// initialization time. Otherwise request that it be installed for use on the // initialization time. Otherwise request that it be installed for use on the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment