Commit ad3701d4 authored by Jack Lynch's avatar Jack Lynch Committed by Commit Bot

DevTools: Performance Event Log duration filter label

This CL adds an aria-label to the select box in the Performance panel
Event Log pane that filters by duration in order to make its purpose
clearer to screen reader users and meet WCAG 1.3.1.

Screenshot of the select in question: https://gyazo.com/9ecb8d9699a05fbb83fcf6f0925f3c47

Bug: 963183
Change-Id: I887f6192b08dbff113d9ac61fa185ffa9ce195ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723804Reviewed-by: default avatarErik Luo <luoe@chromium.org>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#690895}
parent eca91667
......@@ -167,6 +167,7 @@ Timeline.EventsTimelineTreeView.Filters = class extends Common.Object {
Common.UIString('Show all records'),
String(durationMs)));
}
UI.ARIAUtils.setAccessibleName(durationFilterUI.selectElement(), ls`Duration filter`);
toolbar.appendToolbarItem(durationFilterUI);
const categoryFiltersUI = {};
......
......@@ -376,6 +376,9 @@ Click the reload button <ph name="RELOADBUTTON">$3s<ex>reload</ex></ph> or hit <
<message name="IDS_DEVTOOLS_5c593b83b0fca15af4b50ca95c9d3e87" desc="Text in Timeline UIUtils of the Performance panel">
Sign Reply
</message>
<message name="IDS_DEVTOOLS_5e1f827f43b25804948ad57149ad369e" desc="Screen reader label for a select box that filters the Performance panel Event Log by duration.">
Duration filter
</message>
<message name="IDS_DEVTOOLS_5e8170b28aaa693ca9170bb0d65b3043" desc="Text in Timeline UIUtils of the Performance panel">
Destroy WebSocket
</message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment