Commit ad6a0aa0 authored by Tsuyoshi Horo's avatar Tsuyoshi Horo Committed by Commit Bot

Fix flaky SignedExchangeLoaderTest.Simple/1

https://crrev.com/c/1712507 made this test flaky.

Bug: 986337, 983023
Change-Id: I62eb6cb417bf5acce91f88b3b9e85d4c667906b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714294Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680200}
parent aa61e0ef
...@@ -149,13 +149,7 @@ class SignedExchangeLoaderTest : public testing::TestWithParam<bool> { ...@@ -149,13 +149,7 @@ class SignedExchangeLoaderTest : public testing::TestWithParam<bool> {
DISALLOW_COPY_AND_ASSIGN(SignedExchangeLoaderTest); DISALLOW_COPY_AND_ASSIGN(SignedExchangeLoaderTest);
}; };
// Test is flaky on Fuchsia. See https://crbug.com/986337. TEST_P(SignedExchangeLoaderTest, Simple) {
#if defined(OS_FUCHSIA)
#define MAYBE_Simple DISABLED_Simple
#else
#define MAYBE_Simple Simple
#endif
TEST_P(SignedExchangeLoaderTest, MAYBE_Simple) {
network::mojom::URLLoaderPtr loader; network::mojom::URLLoaderPtr loader;
network::mojom::URLLoaderClientPtr loader_client; network::mojom::URLLoaderClientPtr loader_client;
MockURLLoader mock_loader(mojo::MakeRequest(&loader)); MockURLLoader mock_loader(mojo::MakeRequest(&loader));
...@@ -254,6 +248,7 @@ TEST_P(SignedExchangeLoaderTest, MAYBE_Simple) { ...@@ -254,6 +248,7 @@ TEST_P(SignedExchangeLoaderTest, MAYBE_Simple) {
ping_loader_client()->OnReceiveResponse(network::ResourceResponseHead()); ping_loader_client()->OnReceiveResponse(network::ResourceResponseHead());
ping_loader_client()->OnComplete( ping_loader_client()->OnComplete(
network::URLLoaderCompletionStatus(net::OK)); network::URLLoaderCompletionStatus(net::OK));
run_loop.Run();
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment