Don't check occlusion state for hit testing if lifecycle update failed

The first attempt at a fix was reverted, because we can't
CHECK(!NeedsLayout()) at the end of a lifecycle update:

https://chromium-review.googlesource.com/c/chromium/src/+/1972230

BUG=1035029
R=chrishtr@chromium.org

Change-Id: I976c46b13c5a6789ca8df1142269c635cdaa1bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986911Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728359}

third_party/blink/renderer/core/frame/local_frame_view.cc

@@ -2027,9 +2027,9 @@ void LocalFrameView::UpdateGeometriesIfNeeded() {
   views.clear();
 }
 
-void LocalFrameView::UpdateAllLifecyclePhases(
+bool LocalFrameView::UpdateAllLifecyclePhases(
     DocumentLifecycle::LifecycleUpdateReason reason) {
-  GetFrame().LocalFrameRoot().View()->UpdateLifecyclePhases(
+  return GetFrame().LocalFrameRoot().View()->UpdateLifecyclePhases(
       DocumentLifecycle::kPaintClean, reason);
 }
 

third_party/blink/renderer/core/frame/local_frame_view.h

@@ -329,7 +329,8 @@ class CORE_EXPORT LocalFrameView final
   // lifecycle update (e.g., based on visibility) and will not end up being
   // PaintClean. Set |reason| to indicate the reason for this update,
   // for metrics purposes.
-  void UpdateAllLifecyclePhases(
+  // Returns whether the lifecycle was successfully updated to PaintClean.
+  bool UpdateAllLifecyclePhases(
       DocumentLifecycle::LifecycleUpdateReason reason);
 
   // Computes the style, layout, compositing and pre-paint lifecycle stages

third_party/blink/renderer/core/page/page_animator.cc

@@ -138,8 +138,8 @@ void PageAnimator::UpdateAllLifecyclePhases(
   LocalFrameView* view = root_frame.View();
   base::AutoReset<bool> servicing(&updating_layout_and_style_for_painting_,
                                   true);
-  view->UpdateAllLifecyclePhases(reason);
-  UpdateHitTestOcclusionData(root_frame);
+  if (view->UpdateAllLifecyclePhases(reason))
+    UpdateHitTestOcclusionData(root_frame);
 }
 
 void PageAnimator::UpdateAllLifecyclePhasesExceptPaint(LocalFrame& root_frame) {