Commit ad7b2913 authored by Simon La Macchia's avatar Simon La Macchia Committed by Commit Bot

Support Bluetooth keyboard navigation in Search Engine settings

Problem: Currently unable to navigate the Search Engine settings
menu via (Bluetooth) keyboard navigation (up/down/tab/enter keys).
This is because the ListItems in the ListView (contains search
engine choices) are not focusable.

Solution: Make Search Engine settings options focusable, so that
they can navigated and receive click events with a keyboard
(up/down/tab/enter keys).

Bug: 936992
Change-Id: Iee972f689bc497f4393743c0132489715946ea83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495804Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Simon La Macchia <smacchia@amazon.com>
Cr-Commit-Position: refs/heads/master@{#637961}
parent ec3712c4
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
android:background="?android:attr/selectableItemBackground" android:background="?android:attr/selectableItemBackground"
android:gravity="center_vertical" android:gravity="center_vertical"
android:orientation="horizontal" android:orientation="horizontal"
android:focusable="true"
android:padding="6dp"> android:padding="6dp">
<android.widget.RadioButton <android.widget.RadioButton
......
...@@ -47,6 +47,7 @@ public class SearchEnginePreference extends PreferenceFragment { ...@@ -47,6 +47,7 @@ public class SearchEnginePreference extends PreferenceFragment {
mListView = (ListView) getView().findViewById(android.R.id.list); mListView = (ListView) getView().findViewById(android.R.id.list);
mListView.setAdapter(mSearchEngineAdapter); mListView.setAdapter(mSearchEngineAdapter);
mListView.setDivider(null); mListView.setDivider(null);
mListView.setItemsCanFocus(true);
} }
@Override @Override
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment