Clean up all old uses of SpellCheckPanelHost

This CL converts SpellCheckPanelHostPtr|Request to the new Mojo
types. Major changes are as below,

  - Convert mojom::SpellCheckPanelHostPtr to
    mojo::Remote<mojom::SpellCheckPanelHost>
  - Convert mojo::SpellCheckPanelHostRequest to
    mojo::PendingReceiver<mojom::SpellCheckPanelHost>
  - Convert mojo::BindingSet to mojo::ReceiverSet

Bug: 955171
Change-Id: I2e8934227b97a685cb02c9c1a7a00b2ed0b3c746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935967Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719952}

chrome/browser/spellchecker/test/spellcheck_mock_panel_host.cc

@@ -25,9 +25,9 @@ bool SpellCheckMockPanelHost::SpellingPanelVisible() {
   return spelling_panel_visible_;
 }
 
-void SpellCheckMockPanelHost::SpellCheckPanelHostRequest(
-    spellcheck::mojom::SpellCheckPanelHostRequest request) {
-  bindings_.AddBinding(this, std::move(request));
+void SpellCheckMockPanelHost::BindReceiver(
+    mojo::PendingReceiver<spellcheck::mojom::SpellCheckPanelHost> receiver) {
+  receivers_.Add(this, std::move(receiver));
 }
 
 // spellcheck::mojom::SpellCheckPanelHost:

chrome/browser/spellchecker/test/spellcheck_mock_panel_host.h

@@ -8,7 +8,8 @@
 #include "base/callback.h"
 #include "components/spellcheck/common/spellcheck_panel.mojom.h"
 #include "content/public/browser/render_process_host.h"
-#include "mojo/public/cpp/bindings/binding_set.h"
+#include "mojo/public/cpp/bindings/pending_receiver.h"
+#include "mojo/public/cpp/bindings/receiver_set.h"
 
 namespace spellcheck {
 
@@ -20,8 +21,8 @@ class SpellCheckMockPanelHost : public spellcheck::mojom::SpellCheckPanelHost {
   content::RenderProcessHost* process_host() const { return process_host_; }
 
   bool SpellingPanelVisible();
-  void SpellCheckPanelHostRequest(
-      spellcheck::mojom::SpellCheckPanelHostRequest request);
+  void BindReceiver(
+      mojo::PendingReceiver<spellcheck::mojom::SpellCheckPanelHost> receiver);
 
  private:
   // spellcheck::mojom::SpellCheckPanelHost:
@@ -29,7 +30,7 @@ class SpellCheckMockPanelHost : public spellcheck::mojom::SpellCheckPanelHost {
   void UpdateSpellingPanelWithMisspelledWord(
       const base::string16& word) override;
 
-  mojo::BindingSet<spellcheck::mojom::SpellCheckPanelHost> bindings_;
+  mojo::ReceiverSet<spellcheck::mojom::SpellCheckPanelHost> receivers_;
   content::RenderProcessHost* process_host_;
   bool show_spelling_panel_called_ = false;
   bool spelling_panel_visible_ = false;

chrome/browser/spellchecker/test/spellcheck_panel_browsertest_helper.cc

@@ -47,10 +47,14 @@ void SpellCheckPanelBrowserTestHelper::BindSpellCheckPanelHost(
     mojo::PendingReceiver<spellcheck::mojom::SpellCheckPanelHost> receiver) {
   content::RenderProcessHost* render_process_host =
       content::RenderProcessHost::FromID(render_process_id);
-  auto spell_check_panel_host =
-      std::make_unique<SpellCheckMockPanelHost>(render_process_host);
-  spell_check_panel_host->SpellCheckPanelHostRequest(std::move(receiver));
-  hosts_.push_back(std::move(spell_check_panel_host));
+  auto* spell_check_panel_host =
+      GetSpellCheckMockPanelHostForProcess(render_process_host);
+  if (!spell_check_panel_host) {
+    hosts_.push_back(
+        std::make_unique<SpellCheckMockPanelHost>(render_process_host));
+    spell_check_panel_host = hosts_.back().get();
+  }
+  spell_check_panel_host->BindReceiver(std::move(receiver));
   std::move(quit_on_bind_closure_).Run();
 }
 }  // namespace spellcheck

components/spellcheck/renderer/spellcheck_panel.cc

@@ -72,9 +72,10 @@ void SpellCheckPanel::ToggleSpellPanel(bool visible) {
       blink::WebString::FromUTF8("ToggleSpellPanel"));
 }
 
-spellcheck::mojom::SpellCheckPanelHostPtr
+mojo::Remote<spellcheck::mojom::SpellCheckPanelHost>
 SpellCheckPanel::GetSpellCheckPanelHost() {
-  spellcheck::mojom::SpellCheckPanelHostPtr spell_check_panel_host;
-  embedder_provider_->GetInterface(&spell_check_panel_host);
+  mojo::Remote<spellcheck::mojom::SpellCheckPanelHost> spell_check_panel_host;
+  embedder_provider_->GetInterface(
+      spell_check_panel_host.BindNewPipeAndPassReceiver());
   return spell_check_panel_host;
 }

components/spellcheck/renderer/spellcheck_panel.h

@@ -11,6 +11,7 @@
 #include "content/public/renderer/render_frame_observer.h"
 #include "mojo/public/cpp/bindings/pending_receiver.h"
 #include "mojo/public/cpp/bindings/receiver_set.h"
+#include "mojo/public/cpp/bindings/remote.h"
 #include "services/service_manager/public/cpp/binder_registry.h"
 #include "third_party/blink/public/platform/web_spell_check_panel_host_client.h"
 
@@ -49,7 +50,7 @@ class SpellCheckPanel : public content::RenderFrameObserver,
   void ToggleSpellPanel(bool visible) override;
   void AdvanceToNextMisspelling() override;
 
-  spellcheck::mojom::SpellCheckPanelHostPtr GetSpellCheckPanelHost();
+  mojo::Remote<spellcheck::mojom::SpellCheckPanelHost> GetSpellCheckPanelHost();
 
   // SpellCheckPanel receivers.
   mojo::ReceiverSet<spellcheck::mojom::SpellCheckPanel> receivers_;