Commit ad877652 authored by Becky Zhou's avatar Becky Zhou Committed by Commit Bot

[Dark] Update text highlight color on dark mode

Bug: 951227
Change-Id: I388b1ce8955363a2499ac478a7f8978027f690ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572978Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652188}
parent 8ef80a62
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
<color name="default_primary_color">#F2F2F2</color> <color name="default_primary_color">#F2F2F2</color>
<color name="input_underline_error_color">#D32F2F</color> <color name="input_underline_error_color">#D32F2F</color>
<color name="explanation_text_color">#909090</color> <color name="explanation_text_color">#909090</color>
<color name="text_highlight_color">#C6DAFC</color> <color name="text_highlight_color">@color/highlight_color_on_dark_text</color>
<!-- Control colors for toggles, checkboxes, ratio buttons, list item highlight, and accent. <!-- Control colors for toggles, checkboxes, ratio buttons, list item highlight, and accent.
Note that these should NOT be used for icon tint. --> Note that these should NOT be used for icon tint. -->
...@@ -141,7 +141,6 @@ ...@@ -141,7 +141,6 @@
<!-- LocationBar colors --> <!-- LocationBar colors -->
<color name="locationbar_dark_hint_text">@color/search_box_hint</color> <color name="locationbar_dark_hint_text">@color/search_box_hint</color>
<color name="locationbar_light_hint_text">@color/white_alpha_70</color> <color name="locationbar_light_hint_text">@color/white_alpha_70</color>
<color name="locationbar_light_selection_color">#CC5595FE</color>
<color name="locationbar_status_offline_color">@color/modern_grey_900</color> <color name="locationbar_status_offline_color">@color/modern_grey_900</color>
<color name="locationbar_status_offline_color_light">@android:color/white</color> <color name="locationbar_status_offline_color_light">@android:color/white</color>
<color name="locationbar_status_preview_color">@color/modern_blue_600</color> <color name="locationbar_status_preview_color">@color/modern_blue_600</color>
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
<resources> <resources>
<color name="light_active_color">@color/modern_blue_300</color> <color name="light_active_color">@color/modern_blue_300</color>
<color name="control_normal_color">@color/modern_grey_500</color> <color name="control_normal_color">@color/modern_grey_500</color>
<color name="text_highlight_color">@color/highlight_color_on_light_text</color>
<color name="toolbar_text_box_background">@color/modern_grey_800</color> <color name="toolbar_text_box_background">@color/modern_grey_800</color>
......
...@@ -100,7 +100,7 @@ class UrlBarViewBinder { ...@@ -100,7 +100,7 @@ class UrlBarViewBinder {
hintColor = hintColor =
ApiCompatibilityUtils.getColor(resources, R.color.locationbar_light_hint_text); ApiCompatibilityUtils.getColor(resources, R.color.locationbar_light_hint_text);
highlightColor = ApiCompatibilityUtils.getColor( highlightColor = ApiCompatibilityUtils.getColor(
resources, R.color.locationbar_light_selection_color); resources, R.color.highlight_color_on_light_text);
} }
view.setTextColor(textColor); view.setTextColor(textColor);
......
...@@ -59,6 +59,11 @@ ...@@ -59,6 +59,11 @@
<color name="default_text_color_light">@android:color/white</color> <color name="default_text_color_light">@android:color/white</color>
<color name="default_text_color_dark_secondary">@color/modern_grey_700</color> <color name="default_text_color_dark_secondary">@color/modern_grey_700</color>
<!-- TODO(https://crbug.com/953917): Update the highlight colors to meet accessibility
contrast ratio. -->
<color name="highlight_color_on_light_text" tools:ignore="UnusedResources">#CC5595FE</color>
<color name="highlight_color_on_dark_text" tools:ignore="UnusedResources">#C6DAFC</color>
<color name="default_red_light" tools:ignore="UnusedResources">@color/google_red_300</color> <color name="default_red_light" tools:ignore="UnusedResources">@color/google_red_300</color>
<color name="default_red_dark" tools:ignore="UnusedResources">@color/google_red_600</color> <color name="default_red_dark" tools:ignore="UnusedResources">@color/google_red_600</color>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment