Commit ad87cc9c authored by Wez's avatar Wez Committed by Commit Bot

[fuchsia] Clean up old services_unittests filter entries.

If any of these tests exhibit flakes then please disable the test using
the normal DISABLED_ prefix mechanism, and set component:Fuchsia on the
bug, rather than reverting this CL in its entirety.

NetworkContextTest.Preconnect* and TCPBoundSocketTest.ListenError
now pass, likely due to improvements to the platform network stack.

Most TracingConsumerTest.* tests now appear to pass without flakiness,
possibly due to improvements in platform memory-management.

URLLoaderTest.ResourceSchedulerIntegration no longer seems to flake,
possibly due to network stack improvements.

The SimpleURLLoaderTest.OnUploadProgressCallback/* filter entry was no
longer being applied, because the tests had been parameterized, causing
their names to change.

Bug: 952653, 976319, 986544, 1125854, 1125855
Change-Id: Ifc262726675e98e9660b787539ebde5e82ff4872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396337
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805738}
parent a33acce2
...@@ -234,16 +234,19 @@ source_set("tests") { ...@@ -234,16 +234,19 @@ source_set("tests") {
"//services/device/vibration", "//services/device/vibration",
] ]
if (!is_linux_without_udev && !is_android) { if (!is_linux_without_udev) {
sources += [ sources += [
"hid/hid_connection_impl_unittest.cc", "hid/hid_connection_impl_unittest.cc",
"hid/hid_service_unittest.cc",
"hid/input_service_linux_unittest.cc", "hid/input_service_linux_unittest.cc",
"hid/test_report_descriptors.cc", "hid/test_report_descriptors.cc",
"hid/test_report_descriptors.h", "hid/test_report_descriptors.h",
"public/cpp/hid/hid_device_filter_unittest.cc", "public/cpp/hid/hid_device_filter_unittest.cc",
"public/cpp/hid/hid_report_descriptor_unittest.cc", "public/cpp/hid/hid_report_descriptor_unittest.cc",
] ]
if (!is_fuchsia) {
# Fuchsia does not currently implement HidService.
sources += [ "hid/hid_service_unittest.cc" ]
}
if (!is_ios) { if (!is_ios) {
sources += [ "hid/hid_connection_unittest.cc" ] sources += [ "hid/hid_connection_unittest.cc" ]
deps += [ deps += [
......
# https://crbug.com/925652 - There are no |services_|. # https://crbug.com/1125854 - IsTracingEnabled() expectations not met.
-HidServiceTest.GetDevices
# https://crbug.com/925652 - |num_sockets| expectations mismatch.
-NetworkContextTest.PreconnectFour
-NetworkContextTest.PreconnectTwo
# https://crbug.com/925653 - IsTracingEnabled() expectations not met.
-TracingConsumerTest.NotifiesOnTracingEnabledWaitsFor* -TracingConsumerTest.NotifiesOnTracingEnabledWaitsFor*
# https://crbug.com/925653 - Flaky OOM and virtual method crashes. # https://crbug.com/1125855 - Second socket receives too many packets.
-TracingConsumerTest.FlushProducers
-TracingConsumerTest.LargeDataSize
-TracingConsumerTest.PrivacyFilterConfig
-TracingConsumerTest.PrivacyFilterConfigInJson
-TracingConsumerTest.TestConsumerPriority
# https://crbug.com/925653 - Second socket receives too many packets.
-UDPSocketTest.JoinMulticastGroup -UDPSocketTest.JoinMulticastGroup
# https://crbug.com/925653 - Unexpected address-in-use.
-TCPBoundSocketTest.ListenError
# https://crbug.com/976319 - Flakily times-out due to virtualization overhead.
-SimpleURLLoaderTest.OnUploadProgressCallback/*
# https://crbug.com/986544 - Flakes with mismatched state expectations.
-URLLoaderTest.ResourceSchedulerIntegration
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment