Commit adc57df9 authored by Sunny Sachanandani's avatar Sunny Sachanandani Committed by Commit Bot

gpu: Ensure result of CreateTexture2D shows up in minidump

hr is read from eax as 0 (S_OK) in minidumps, but that's not possible
since the CHECK fails. base::debug::Alias is a sure way of seeing the
value in minidumps.

R=piman
BUG=794735

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a92c2967cf6786c6540c49fcacfc97b888fa146
Reviewed-on: https://chromium-review.googlesource.com/998734Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548583}
parent 67aabc73
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include <d3d11_1.h> #include <d3d11_1.h>
#include "base/debug/alias.h"
#include "third_party/khronos/EGL/egl.h" #include "third_party/khronos/EGL/egl.h"
#include "third_party/khronos/EGL/eglext.h" #include "third_party/khronos/EGL/eglext.h"
#include "ui/gl/gl_angle_util_win.h" #include "ui/gl/gl_angle_util_win.h"
...@@ -236,6 +237,8 @@ bool CopyingGLImageDXGI::Initialize() { ...@@ -236,6 +237,8 @@ bool CopyingGLImageDXGI::Initialize() {
HRESULT hr = d3d11_device_->CreateTexture2D( HRESULT hr = d3d11_device_->CreateTexture2D(
&desc, nullptr, decoder_copy_texture_.GetAddressOf()); &desc, nullptr, decoder_copy_texture_.GetAddressOf());
// TODO(sunnyps): Remove after fixing https://crbug.com/794735
base::debug::Alias(&hr);
CHECK(SUCCEEDED(hr)); CHECK(SUCCEEDED(hr));
EGLDisplay egl_display = gl::GLSurfaceEGL::GetHardwareDisplay(); EGLDisplay egl_display = gl::GLSurfaceEGL::GetHardwareDisplay();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment