Commit ade9f1af authored by teravest@chromium.org's avatar teravest@chromium.org

Pepper: Remove PluginReverseInterface::Log.

ReverseInterface::Log was removed from native_client, since it was 
never used. Now we can remove this implementation as well.

BUG=239656

Review URL: https://codereview.chromium.org/170663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251852 0039d316-1c4b-4281-b951-d872f2087c98
parent 316cc660
...@@ -99,19 +99,6 @@ void PluginReverseInterface::ShutDown() { ...@@ -99,19 +99,6 @@ void PluginReverseInterface::ShutDown() {
NaClLog(4, "PluginReverseInterface::Shutdown: broadcasted, exiting\n"); NaClLog(4, "PluginReverseInterface::Shutdown: broadcasted, exiting\n");
} }
void PluginReverseInterface::Log(nacl::string message) {
LogToJavaScriptConsoleResource* continuation =
new LogToJavaScriptConsoleResource(message);
CHECK(continuation != NULL);
NaClLog(4, "PluginReverseInterface::Log(%s)\n", message.c_str());
plugin::WeakRefCallOnMainThread(
anchor_,
0, /* delay in ms */
this,
&plugin::PluginReverseInterface::Log_MainThreadContinuation,
continuation);
}
void PluginReverseInterface::DoPostMessage(nacl::string message) { void PluginReverseInterface::DoPostMessage(nacl::string message) {
PostMessageResource* continuation = new PostMessageResource(message); PostMessageResource* continuation = new PostMessageResource(message);
CHECK(continuation != NULL); CHECK(continuation != NULL);
...@@ -138,15 +125,6 @@ void PluginReverseInterface::StartupInitializationComplete() { ...@@ -138,15 +125,6 @@ void PluginReverseInterface::StartupInitializationComplete() {
} }
} }
void PluginReverseInterface::Log_MainThreadContinuation(
LogToJavaScriptConsoleResource* p,
int32_t err) {
UNREFERENCED_PARAMETER(err);
NaClLog(4,
"PluginReverseInterface::Log_MainThreadContinuation(%s)\n",
p->message.c_str());
plugin_->AddToConsole(p->message);
}
void PluginReverseInterface::PostMessage_MainThreadContinuation( void PluginReverseInterface::PostMessage_MainThreadContinuation(
PostMessageResource* p, PostMessageResource* p,
int32_t err) { int32_t err) {
......
...@@ -73,14 +73,6 @@ struct SelLdrStartParams { ...@@ -73,14 +73,6 @@ struct SelLdrStartParams {
}; };
// Callback resources are essentially our continuation state. // Callback resources are essentially our continuation state.
struct LogToJavaScriptConsoleResource {
public:
explicit LogToJavaScriptConsoleResource(std::string msg)
: message(msg) {}
std::string message;
};
struct PostMessageResource { struct PostMessageResource {
public: public:
explicit PostMessageResource(std::string msg) explicit PostMessageResource(std::string msg)
...@@ -157,8 +149,6 @@ class PluginReverseInterface: public nacl::ReverseInterface { ...@@ -157,8 +149,6 @@ class PluginReverseInterface: public nacl::ReverseInterface {
void ShutDown(); void ShutDown();
virtual void Log(nacl::string message);
virtual void DoPostMessage(nacl::string message); virtual void DoPostMessage(nacl::string message);
virtual void StartupInitializationComplete(); virtual void StartupInitializationComplete();
...@@ -183,9 +173,6 @@ class PluginReverseInterface: public nacl::ReverseInterface { ...@@ -183,9 +173,6 @@ class PluginReverseInterface: public nacl::ReverseInterface {
void AddTempQuotaManagedFile(const nacl::string& file_id); void AddTempQuotaManagedFile(const nacl::string& file_id);
protected: protected:
virtual void Log_MainThreadContinuation(LogToJavaScriptConsoleResource* p,
int32_t err);
virtual void PostMessage_MainThreadContinuation(PostMessageResource* p, virtual void PostMessage_MainThreadContinuation(PostMessageResource* p,
int32_t err); int32_t err);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment