Commit ae0450f7 authored by Will Harris's avatar Will Harris Committed by Commit Bot

Revert "--no-sandbox is added for Windows ASAN."

This reverts commit 384ba48b.

Reason for revert: This might not be needed.

Original change's description:
> --no-sandbox is added for Windows ASAN.
> 
> As sandbox is not yet supported by ASAN in Windows, it's better to add
> --no-sandbox there.
> 
> Change-Id: I38430c95b4a0f5cfeee3ab389ddcb3e78721c027
> Reviewed-on: https://chromium-review.googlesource.com/968421
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544765}

TBR=dpranke@chromium.org,voodoo@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4cf38262948857daddbd4498745181c733607136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711897Reviewed-by: default avatarWill Harris <wfh@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarAbhishek Arya <inferno@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680025}
parent 0ec24f17
......@@ -1309,11 +1309,6 @@ class MetaBuildWrapper(object):
self.WriteFailureAndRaise('No command line for %s found (test type %s).'
% (target, test_type), output_path=None)
if is_win and asan:
# Sandbox is not yet supported by ASAN for Windows.
# Perhaps this is only needed for tests that use the sandbox?
cmdline.append('--no-sandbox')
cmdline += isolate_map[target].get('args', [])
return cmdline, extra_files
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment