[Qt] Fixes premature plugin unload bug

https://bugs.webkit.org/show_bug.cgi?id=66628

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.

The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.

* WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::loadSpellChecker):
* WebCoreSupport/TextCheckerClientQt.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@93490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/WebKit/qt/ChangeLog

+2011-08-21  Lindsay Mathieson  <lindsay.mathieson@gmail.com>
+
+        [Qt] Fixes premature plugin unload bug
+        https://bugs.webkit.org/show_bug.cgi?id=66628
+        
+        Reviewed by Benjamin Poulain.
+
+        The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
+        plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
+        to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
+        of plugin.            
+        
+        * WebCoreSupport/TextCheckerClientQt.cpp:
+        (WebCore::TextCheckerClientQt::loadSpellChecker):
+        * WebCoreSupport/TextCheckerClientQt.h:
+
 2011-08-17  Adam Roben  <aroben@apple.com>
 
         Make WebCore keep track of the current device scale factor

third_party/WebKit/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp

@@ -152,8 +152,7 @@ bool TextCheckerClientQt::loadSpellChecker()
     if (m_spellChecker)
         return true;
 
-    QtPlatformPlugin platformPlugin;
-    if ((m_spellChecker = platformPlugin.createSpellChecker()))
+    if ((m_spellChecker = m_platformPlugin.createSpellChecker()))
         return true;
 
     return false;

third_party/WebKit/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h

@@ -29,6 +29,7 @@
 #ifndef TextCheckerClientQt_h
 #define TextCheckerClientQt_h
 
+#include "QtPlatformPlugin.h"
 #include "TextCheckerClient.h"
 #include "qwebkitplatformplugin.h"
 
@@ -58,6 +59,7 @@ private:
     bool loadSpellChecker();
 
 private:
+    QtPlatformPlugin m_platformPlugin;
     OwnPtr<QWebSpellChecker> m_spellChecker;
 };