Commit ae499b4e authored by Dominic Farolino's avatar Dominic Farolino Committed by Commit Bot

Prefetch: Use CrashKeys instead of aliased stack variables for DumpWithoutCrashing

Bug: 1132770
Change-Id: Ie6d881707594ddae9a5ff12f9e5a373e89114db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550585Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829343}
parent 630f1ca7
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "content/browser/loader/prefetch_url_loader_service.h" #include "content/browser/loader/prefetch_url_loader_service.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h" #include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/time/default_tick_clock.h" #include "base/time/default_tick_clock.h"
...@@ -31,8 +32,10 @@ ...@@ -31,8 +32,10 @@
namespace { namespace {
void DumpWithoutCrashing(const network::ResourceRequest& request) { void DumpWithoutCrashing(const network::ResourceRequest& request) {
DEBUG_ALIAS_FOR_GURL(prefetch_buf, request.url); std::string prefetch_url = request.url.spec();
DEBUG_ALIAS_FOR_GURL(initiator_buf, request.request_initiator->GetURL()); std::string initiator_url = request.request_initiator->GetURL().spec();
SCOPED_CRASH_KEY_STRING256(Crbug1132770, PrefetchURL, prefetch_url);
SCOPED_CRASH_KEY_STRING256(Crbug1132770, InitiatorURL, initiator_url);
base::debug::DumpWithoutCrashing(); base::debug::DumpWithoutCrashing();
} }
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment