Commit ae49cb49 authored by Kai Ninomiya's avatar Kai Ninomiya Committed by Commit Bot

Suppress CopyType/GLCopyTextureCHROMIUMES3Test.FormatCombinations on Apple DTK

TBR: jdarpinian@chromium.org
Bug: 1135372
Change-Id: I60e715580de1559e3102a5e40acbfbaf9a30a140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450846
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: default avatarKai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814314}
parent d445bff7
...@@ -678,6 +678,15 @@ class GLCopyTextureCHROMIUMES3Test : public GLCopyTextureCHROMIUMTest { ...@@ -678,6 +678,15 @@ class GLCopyTextureCHROMIUMES3Test : public GLCopyTextureCHROMIUMTest {
EXPECT_TRUE(supports_rgb10_a2); EXPECT_TRUE(supports_rgb10_a2);
return !supports_rgb10_a2; return !supports_rgb10_a2;
} }
bool IsMacArm64() const {
DCHECK(!ShouldSkipTest());
#if defined(OS_MAC) && defined(ARCH_CPU_ARM_FAMILY)
return true;
#else
return false;
#endif
}
}; };
INSTANTIATE_TEST_SUITE_P(CopyType, INSTANTIATE_TEST_SUITE_P(CopyType,
...@@ -739,6 +748,10 @@ TEST_P(GLCopyTextureCHROMIUMES3Test, BigTexture) { ...@@ -739,6 +748,10 @@ TEST_P(GLCopyTextureCHROMIUMES3Test, BigTexture) {
TEST_P(GLCopyTextureCHROMIUMES3Test, FormatCombinations) { TEST_P(GLCopyTextureCHROMIUMES3Test, FormatCombinations) {
if (ShouldSkipTest()) if (ShouldSkipTest())
return; return;
if (IsMacArm64()) {
LOG(INFO) << "TODO(crbug.com/1135372): fails on Apple DTK. Skipping.";
return;
}
if (gl_.gpu_preferences().use_passthrough_cmd_decoder) { if (gl_.gpu_preferences().use_passthrough_cmd_decoder) {
// TODO(geofflang): anglebug.com/1932 // TODO(geofflang): anglebug.com/1932
LOG(INFO) LOG(INFO)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment