Commit ae4de2d6 authored by nancy's avatar nancy Committed by Commit Bot

Update uninstall dialog heading from Remove to Uninstall.

Currently, the uninstallation dialog head text is inconsistency for the
ARC apps and extension apps. ARC apps use Uninstall, and Remove for the
shortcut only, because for the shortcut, ARC apps use the extension
apps' IDS_EXTENSION_UNINSTALL_PROMPT_HEADING. Per request from the bug,
change the head text from Remove to Uninstall, and remove the quotes.
Linux apps use Uninstall as well, so I think Uninstall sounds better.

BUG=1010303
TBR=rdevlin.cronin@chromium.org

Change-Id: I0e939943c37c295ebe2c8a73824c235420a98195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844756Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704004}
parent 8da434a8
...@@ -3492,7 +3492,7 @@ are declared in tools/grit/grit_rule.gni. ...@@ -3492,7 +3492,7 @@ are declared in tools/grit/grit_rule.gni.
Add "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"? Add "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"?
</message> </message>
<message name="IDS_EXTENSION_UNINSTALL_PROMPT_HEADING" desc="First bold line in the content area of the extension or app uninstallation prompt. Asks the user if they want to uninstall a particular extension or app."> <message name="IDS_EXTENSION_UNINSTALL_PROMPT_HEADING" desc="First bold line in the content area of the extension or app uninstallation prompt. Asks the user if they want to uninstall a particular extension or app.">
Remove "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"? Uninstall <ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>?
</message> </message>
<message name="IDS_EXTENSION_PROGRAMMATIC_UNINSTALL_PROMPT_HEADING" desc="First bold line in the content area of the extension or app uninstallation prompt when the uninstallation is programmatically triggered by another extension. Asks the user if they want to uninstall a particular extension or app."> <message name="IDS_EXTENSION_PROGRAMMATIC_UNINSTALL_PROMPT_HEADING" desc="First bold line in the content area of the extension or app uninstallation prompt when the uninstallation is programmatically triggered by another extension. Asks the user if they want to uninstall a particular extension or app.">
"<ph name="TRIGGERING_EXTENSION_NAME">$1<ex>Extension Manager</ex></ph>" would like to remove "<ph name="EXTENSION_NAME">$2<ex>Gmail Checker</ex></ph>". "<ph name="TRIGGERING_EXTENSION_NAME">$1<ex>Extension Manager</ex></ph>" would like to remove "<ph name="EXTENSION_NAME">$2<ex>Gmail Checker</ex></ph>".
...@@ -4258,7 +4258,7 @@ Keep your key file in a safe place. You will need it to create new versions of y ...@@ -4258,7 +4258,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
Report abuse from "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>" Report abuse from "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"
</message> </message>
<message name="IDS_EXTENSION_PROMPT_UNINSTALL_TITLE" desc="Title text for removing an extension."> <message name="IDS_EXTENSION_PROMPT_UNINSTALL_TITLE" desc="Title text for removing an extension.">
Remove "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"? Uninstall <ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>?
</message> </message>
<message name="IDS_EXTENSION_PROMPT_UNINSTALL_APP_BUTTON" desc="Text for the uninstall button on the non-platform app and ARC(App Runtime for Chrome) app uninstall prompt"> <message name="IDS_EXTENSION_PROMPT_UNINSTALL_APP_BUTTON" desc="Text for the uninstall button on the non-platform app and ARC(App Runtime for Chrome) app uninstall prompt">
Uninstall Uninstall
......
e902b07e3e1424692c643628b124f58d746e3ad8
\ No newline at end of file
0f2448350c91b414100ca3e56ea493fc40796335
\ No newline at end of file
...@@ -367,7 +367,7 @@ TEST_F(ManagementApiUnitTest, ManagementWebStoreUninstall) { ...@@ -367,7 +367,7 @@ TEST_F(ManagementApiUnitTest, ManagementWebStoreUninstall) {
bool did_show = false; bool did_show = false;
auto callback = base::BindRepeating( auto callback = base::BindRepeating(
[](bool* did_show, extensions::ExtensionUninstallDialog* dialog) { [](bool* did_show, extensions::ExtensionUninstallDialog* dialog) {
EXPECT_EQ("Remove \"Test\"?", dialog->GetHeadingText()); EXPECT_EQ("Uninstall Test?", dialog->GetHeadingText());
*did_show = true; *did_show = true;
}, },
&did_show); &did_show);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment