Commit ae60643b authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Remove usages of debug_devtools in chrome/BUILD.gn

The flag is being removed. Before we can remove the usages in
devtools-frontend itself, we first have to remove the references to them
in Chromium.

R=yangguo@chromium.org

Bug: 1087379
Change-Id: I09650358aba4bc2ec30fe91fe49e7e287d4b205b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224216
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774636}
parent 2197b5a0
...@@ -370,10 +370,6 @@ if (is_win) { ...@@ -370,10 +370,6 @@ if (is_win) {
data_deps = [ ":chrome_app" ] data_deps = [ ":chrome_app" ]
if (debug_devtools) {
deps += [ ":devtools_debug_resources" ]
}
if (verify_dynamic_libraries) { if (verify_dynamic_libraries) {
deps += [ ":verify_libraries_chrome_app" ] deps += [ ":verify_libraries_chrome_app" ]
} }
...@@ -772,44 +768,6 @@ if (is_win) { ...@@ -772,44 +768,6 @@ if (is_win) {
} }
} }
# When debug_devtools is enabled, symlink the inspector resources into the
# framework bundle. The resources go into the final output directory for the
# framework in the app bundle, rather than the framework bundle in
# root_out_dir, since copy_bundle_data copies the contents of the link
# rather than the link itself.
if (debug_devtools) {
action("devtools_debug_resources") {
_stamp = "$target_out_dir/run_${target_name}.stamp"
outputs = [ _stamp ]
script = "//build/symlink.py"
args = [
"-f",
"--touch",
rebase_path(_stamp, root_out_dir),
# Convert the symlink source and destination to an absolute paths, which
# makes symlinking easier (now pwd manipulation).
rebase_path("$root_out_dir/resources/inspector"),
rebase_path(
"$root_out_dir/$chrome_product_full_name.app/Contents/Frameworks/$chrome_framework_name.framework/Versions/$chrome_version_full/Resources/inspector"),
]
deps = [
# Depend on :chrome_app to ensure that the bundle is produced before
# creating or destroying the symlink.
":chrome_app",
"//third_party/blink/public:blink_devtools_frontend_resources",
"//third_party/blink/public:blink_devtools_inspector_resources",
]
}
} else {
group("devtools_debug_resources") {
}
}
if (enable_nacl) { if (enable_nacl) {
bundle_data("chrome_framework_plugins") { bundle_data("chrome_framework_plugins") {
sources = [] sources = []
......
...@@ -473,18 +473,12 @@ machine? ...@@ -473,18 +473,12 @@ machine?
### Debugging DevTools Tests ### Debugging DevTools Tests
* Add `debug_devtools=true` to `args.gn` and compile: `autoninja -C out/Default devtools_frontend_resources`
> Debug DevTools lets you avoid having to recompile after every change to the DevTools front-end.
* Do one of the following: * Do one of the following:
* Option A) Run from the `chromium/src` folder: * Option A) Run from the `chromium/src` folder:
`third_party/blink/tools/run_web_tests.sh `third_party/blink/tools/run_web_tests.py --additional-driver-flag='--remote-debugging-port=9222' --additional-driver-flag='--debug-devtools' --time-out-ms=6000000`
--additional-driver-flag='--debug-devtools'
--additional-driver-flag='--remote-debugging-port=9222'
--time-out-ms=6000000`
* Option B) If you need to debug an http/tests/inspector test, start httpd * Option B) If you need to debug an http/tests/inspector test, start httpd
as described above. Then, run content_shell: as described above. Then, run content_shell:
`out/Default/content_shell --debug-devtools --remote-debugging-port=9222 --run-web-tests `out/Default/content_shell --remote-debugging-port=9222 --additional-driver-flag='--debug-devtools' --run-web-tests http://127.0.0.1:8000/path/to/test.html`
http://127.0.0.1:8000/path/to/test.html`
* Open `http://localhost:9222` in a stable/beta/canary Chrome, click the single * Open `http://localhost:9222` in a stable/beta/canary Chrome, click the single
link to open the devtools with the test loaded. link to open the devtools with the test loaded.
* In the loaded devtools, set any required breakpoints and execute `test()` in * In the loaded devtools, set any required breakpoints and execute `test()` in
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment