[WPT/common/security-features] Faster generator by less json.dumps()
Previously, dump_test_parameters() (which uses json.dumps()) was used to calculate the keys of `exclusion_dict`, so that the keys of `exclusion_dict` include all the fields of the selections. However, this was slow. This CL instead uses `excluded_selection_pattern % selection` where excluded_selection_pattern incudes "`%(key)s`" for all the keys of the selections, except for "expansion". (The exclusion of "expansion" is probably good, as differences in "expansion" fields shouldn't prevent excluded test matching) This CL improves the generator's performance about 5x. This CL doesn't change the generated results or test behavior. Bug: 906850 Change-Id: I67f2cf6e960d7867a9b409cb84bf8249ac1912c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100562 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750484}
Showing
Please register or sign in to comment