bookmarks: Remove dead code about node visibility

The APIs haven't been used in a long while, presumably after
https://crrev.com/1454983004.

Change-Id: I1bfbc537663348e0e6c74f0a82e3df77911037d6
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095576Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748723}

components/bookmarks/browser/bookmark_model.cc

@@ -47,11 +47,6 @@ BookmarkNode* AsMutable(const BookmarkNode* node) {
   return const_cast<BookmarkNode*>(node);
 }
 
-// Helper to get a mutable permanent bookmark node.
-BookmarkPermanentNode* AsMutable(const BookmarkPermanentNode* node) {
-  return const_cast<BookmarkPermanentNode*>(node);
-}
-
 // Comparator used when sorting permanent nodes. Nodes that are initially
 // visible are sorted before nodes that are initially hidden.
 class VisibilityComparator {
@@ -774,31 +769,6 @@ void BookmarkModel::ClearStore() {
   store_.reset();
 }
 
-void BookmarkModel::SetPermanentNodeVisible(BookmarkNode::Type type,
-                                            bool value) {
-  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  BookmarkPermanentNode* node = AsMutable(PermanentNode(type));
-  node->set_visible(value || client_->IsPermanentNodeVisible(node));
-}
-
-const BookmarkPermanentNode* BookmarkModel::PermanentNode(
-    BookmarkNode::Type type) {
-  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  DCHECK(loaded_);
-
-  switch (type) {
-    case BookmarkNode::BOOKMARK_BAR:
-      return bookmark_bar_node_;
-    case BookmarkNode::OTHER_NODE:
-      return other_node_;
-    case BookmarkNode::MOBILE:
-      return mobile_node_;
-    default:
-      NOTREACHED();
-      return nullptr;
-  }
-}
-
 void BookmarkModel::RestoreRemovedNode(const BookmarkNode* parent,
                                        size_t index,
                                        std::unique_ptr<BookmarkNode> node) {

components/bookmarks/browser/bookmark_model.h

@@ -277,14 +277,6 @@ class BookmarkModel : public BookmarkUndoProvider,
     return expanded_state_tracker_.get();
   }
 
-  // Sets the visibility of one of the permanent nodes (unless the node must
-  // always be visible, see |BookmarkClient::IsPermanentNodeVisible| for more
-  // details). This is set by sync.
-  void SetPermanentNodeVisible(BookmarkNode::Type type, bool value);
-
-  // Returns the permanent node of type |type|.
-  const BookmarkPermanentNode* PermanentNode(BookmarkNode::Type type);
-
   // Sets/deletes meta info of |node|.
   void SetNodeMetaInfo(const BookmarkNode* node,
                        const std::string& key,

components/bookmarks/browser/bookmark_model_unittest.cc

@@ -1124,17 +1124,6 @@ TEST_F(BookmarkModelTest, NodeVisibility) {
   EXPECT_TRUE(model_->other_node()->IsVisible());
   EXPECT_FALSE(model_->mobile_node()->IsVisible());
 
-  // Visibility of permanent node can only be changed if they are not
-  // forced to be visible by the client.
-  model_->SetPermanentNodeVisible(BookmarkNode::BOOKMARK_BAR, false);
-  EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
-  model_->SetPermanentNodeVisible(BookmarkNode::OTHER_NODE, false);
-  EXPECT_TRUE(model_->other_node()->IsVisible());
-  model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, true);
-  EXPECT_TRUE(model_->mobile_node()->IsVisible());
-  model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, false);
-  EXPECT_FALSE(model_->mobile_node()->IsVisible());
-
   // Arbitrary node should be visible
   TestNode bbn;
   PopulateNodeFromString("B", &bbn);