Revert "Reland "PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks.""
This reverts commit 474b44df. Reason for revert: Whoops. Reverting due to the prod freeze. Original change's description: > Reland "PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks." > > This is a reland of e6d6e338 > > CheckDirMetadataFormat returns a list of input_api.Command objects, > which are not derived from output_api.PresubmitResult. > > Fixed by running it using input_api.RunTests. > > Original change's description: > > PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks. > > > > checkteamtags is no longer necessary. > > - Add a check to validate DIR_METADATA files. > > This obviates the need fo checkteamtags, as `dirmd` validates metadata in > > OWNERS files, and we no longer need to enforce a unique team email for all > > (component, OS) pair. > > - Add a check to enforce that OWNERS files contain no metadata if a > > DIR_METADATA file is present in the same directory. > > > > Bug: 1102997 > > Change-Id: I661f7a1958824e7d20642d65534c2502d1a050e2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317838 > > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791884} > > Bug: 1102997 > Change-Id: Iff7d2569ee4e9a5a66773dba47e2de8e3c8f9b82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321550 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792486} TBR=dpranke@google.com,nodir@chromium.org,ehmaldonado@chromium.org Change-Id: I6641555670408ef276296b927a9b8f925e5335a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324556Reviewed-by:Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#792487}
Showing
Please register or sign in to comment