Commit aebe4351 authored by Aleks Totic's avatar Aleks Totic Committed by Chromium LUCI CQ

[TablesNG] virtual wpt/css/css-tables test suite

Turn on TablesNG virtual test suite.
23 tests that used to fail in Legacy now pass.

14 tests in the test suite are still failing.

5 fail because of  incorrect anonymous table fixup.
virtual/layout_ng_table/external/wpt/css/css-tables/anonymous-table-ws-001.html
virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-001.html
virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-002.html
virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-table-001.html
virtual/layout_ng_table/external/wpt/css/css-tables/table-model-fixup-2.html

3 fail because "ignore percent inside flex/grid/td" has not landed
virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-001.tentative.html
virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-003.tentative.html
virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children.html

2 fail because "caption-side:left is not implemented"
virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006b.xht
virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006c.xht

1 fail because "table height distribution to rows does not distribute to head"
filed an issue
virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-004.html

2 fail because "rowspan + visibility:collapse differ from standard"
virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-colspan-003.html
virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowspan-005.html

I think
virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/computing-row-measure-0.html
is a bad test. We match FF, will check with dgrogan

Bug: 958381
Change-Id: I08e7713e908638262d61cd0742e2bf0b77ed0b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586269
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836227}
parent 4e45a84f
......@@ -5019,11 +5019,43 @@ crbug.com/970285 [ Android ] virtual/forced-high-contrast-colors/* [ Pass ]
crbug.com/1090660 external/wpt/css/css-color-adjust/rendering/dark-color-scheme/svg-as-image.html [ Skip ]
crbug.com/1090660 virtual/dark-color-scheme/external/wpt/css/css-color-adjust/rendering/dark-color-scheme/svg-as-image.html [ Pass ]
# virtual/layout_ng_table
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/border-spacing-included-in-sizes-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/min-max-size-table-content-box.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/subpixel-collapsed-borders-003.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/subpixel-table-cell-height-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/subpixel-table-cell-width-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/subpixel-table-cell-width-002.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/subpixel-table-width-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/table-has-box-sizing-border-box-002.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/toggle-row-display-property-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-col-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-col-002.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-col-003.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-col-004-dynamic.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-col-005.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-colspan-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-colspan-002.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-row-004.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowcol-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowcol-002.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-001.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-003.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-005.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-005.html [ Pass ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/tentative/position-sticky-container.html [ Pass ]
crbug.com/1157330 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/computing-row-measure-0.html [ Failure ]
crbug.com/1157626 virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowspan-005.html [ Failure ]
# Works in main table patch, needs percentage sizing fix.
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children.html [ Failure ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-001.tentative.html [ Failure ]
crbug.com/958381 virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-003.tentative.html [ Failure ]
# Sheriff 2019-08-14
crbug.com/993671 [ Win ] http/tests/media/video-frame-size-change.html [ Pass Failure ]
#Sheriff 2019-08-12
#Sherrif 2019-08-16
crbug.com/994692 [ Linux ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ]
crbug.com/994692 [ Win ] compositing/reflections/nested-reflection-anchor-point.html [ Pass Failure ]
......
......@@ -286,6 +286,11 @@
"external/wpt/css/css-grid"],
"args": ["--enable-blink-features=LayoutNGGrid"]
},
{
"prefix": "layout_ng_table",
"bases": [ "external/wpt/css/css-tables" ],
"args": ["--enable-blink-features=LayoutNGTable"]
},
{
"prefix": "dark-mode-default",
"bases": ["dark-mode/colors",
......
Baselines for TablesNG virtual suite.
crbug.com/958381
owner: atotic@chromium.org
Baselines for TablesNG virtual suite.
crbug.com/958381
owner: atotic@chromium.org
This is a testharness.js-based test.
PASS Control test: Table width is 120px
PASS Control test: Table height is 120px
PASS Table-cell is 100px wide
PASS Table-cell is 100px tall
PASS Table-row is 100px wide
PASS Table-row is 100px tall
PASS Table-row-group is 100px wide
PASS Table-row-group is 100px tall
PASS Table-column is 100px wide
PASS Table-column is 100px tall
PASS Table-column-group is 100px wide
PASS Table-column-group is 100px tall
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Control test: Table width is 120px
PASS Control test: Table height is 120px
PASS Table-cell is 100px wide
PASS Table-cell is 100px tall
PASS Table-row is 100px wide
PASS Table-row is 100px tall
PASS Table-row-group is 100px wide
PASS Table-row-group is 100px tall
PASS Table-column is 100px wide
PASS Table-column is 100px tall
PASS Table-column-group is 100px wide
PASS Table-column-group is 100px tall
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Control test: Table width is 120px
PASS Control test: Table height is 120px
FAIL First (empty) table-row-group is 0px wide assert_equals: expected 0 but got 100
PASS First (empty) table-row-group is 0px tall
PASS First (empty) table-row-group should be located at 10px left
FAIL First (empty) table-row-group should be located at 10px top assert_equals: expected 10 but got 0
PASS Second table-row-group is 100px wide
PASS Second table-row-group is 100px tall
PASS Second table-row-group should be located at 10px left
PASS Second table-row-group should be located at 10px top
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Empty tables can still get a lsyout
FAIL Empty tables do not take table-columns into account assert_equals: expected 50 but got 200
FAIL Empty tables do not take table-rows into account assert_equals: expected 50 but got 100
PASS Table-columns are taken into account after missing cells are generated (empty line)
PASS Table-columns are taken into account after missing cells are generated (partially empty line)
PASS Table-columns are taken into account after missing cells are generated (non-empty line)
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Explicitely defined columns are not merged
PASS Explicitely defined rows are not merged
PASS Border-spacing is added between any two unmerged columns (1)
PASS Border-spacing is added between any two unmerged rows (1)
PASS Border-spacing is added between any two unmerged columns (2)
PASS Border-spacing is added between any two unmerged rows (2)
PASS Border-spacing is added between any two unmerged columns (3)
PASS Border-spacing is added between any two unmerged rows (3)
PASS Border-spacing is added between any two unmerged columns (4)
PASS Border-spacing is added between any two unmerged rows (4)
PASS Border-spacing is added between any two unmerged columns (5)
PASS Border-spacing is added between any two unmerged rows (5)
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Redundant columns of fixed-layout tables are not being merged
PASS Redundant rows of fixed-layout tables are not being merged
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS table 1
PASS table 2
PASS table 3
PASS table 4
PASS table 5
PASS table 6
PASS table 7
PASS table 8
PASS table 9
PASS table 10
PASS table 11
PASS table 12
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS table 1
PASS table 2
PASS table 3
PASS table 4
PASS table 5
PASS table 6
PASS table 7
PASS table 8
PASS table 9
PASS table 10
PASS table 11
PASS table 12
PASS table 13
PASS table 14
PASS table 15
PASS table 16
PASS table 17
PASS table 18
PASS table 19
PASS table 20
PASS table 21
PASS table 22
PASS table 23
PASS table 24
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS table 1
PASS table 2
PASS table 3
PASS table 4
PASS table 5
PASS table 6
PASS table 7
PASS table 8
PASS table 9
PASS table 10
PASS table 11
PASS table 12
PASS table 13
PASS table 14
PASS table 15
PASS table 16
PASS table 17
PASS table 18
PASS table 19
PASS table 20
PASS table 21
PASS table 22
PASS table 23
PASS table 24
PASS table 25
PASS table 26
PASS table 27
PASS table 28
PASS table 29
PASS table 30
PASS table 31
PASS table 32
PASS table 33
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Checking intermediate min-content height for span 2 (1)
PASS Checking intermediate min-content height for span 2 (2)
PASS Checking intermediate min-content height for span 2 (3)
PASS Checking intermediate min-content height for span 2 (4)
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment