Commit aece6748 authored by Azeem Arshad's avatar Azeem Arshad Committed by Commit Bot

[Network Details] Fix aria labels for manual proxy exception list items

This CL fixes issue with manual proxy config exception list items being
read out incorrectly in ChromveVOX and removes unnecessary tab stop.

Fixed: 1024355
Change-Id: Ie2a24f36c072a7b451135a274d0ec15320a924c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915319Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715164}
parent 92c963d2
......@@ -2224,6 +2224,9 @@
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_LIST" desc="Settings > Internet > Network details: Label for list of network proxy exceptions.">
Do not use the proxy settings for these hosts and domains:
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPT_REMOVE_ACCESSIBILITY_LABEL" desc="Settings > Internet > Network details: Accessibility only label for button to remove proxy exception.">
Remove exception for <ph name="HOST_NAME">$1<ex>example.com</ex></ph>
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_ADD_EXCEPTION" desc="Settings > Internet > Network details: Label for button to add a network proxy exception.">
Add exception
</message>
......
......@@ -197,6 +197,8 @@ void AddDetailsLocalizedStrings(content::WebUIDataSource* html_source) {
IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_INPUT_ACCESSIBILITY_LABEL},
{"networkProxyExceptionList",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_LIST},
{"networkProxyExceptionRemoveA11yLabel",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPT_REMOVE_ACCESSIBILITY_LABEL},
{"networkProxyFtp", IDS_SETTINGS_INTERNET_NETWORK_PROXY_FTP_PROXY},
{"networkProxyHostInputA11yLabel",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_HOST_INPUT_ACCESSIBILITY_LABEL},
......
......@@ -3,6 +3,7 @@
<link rel="import" href="chrome://resources/cr_elements/cr_icon_button/cr_icon_button.html">
<link rel="import" href="chrome://resources/cr_elements/hidden_style_css.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="network_shared_css.html">
<dom-module id="network-proxy-exclusions">
......@@ -23,10 +24,11 @@
</style>
<div id="container">
<template is="dom-repeat" items="[[exclusions]]">
<div class="layout horizontal center" tabindex="0" >
<div class="layout horizontal center">
<div class="flex">[[item]]</div>
<cr-icon-button class="icon-clear" hidden="[[!editable]]"
title="$i18n{remove}" on-click="onRemoveTap_">
title="[[i18n('networkProxyExceptionRemoveA11yLabel', item)]]"
on-click="onRemoveTap_">
</cr-icon-button>
</div>
</template>
......
......@@ -12,6 +12,8 @@
Polymer({
is: 'network-proxy-exclusions',
behaviors: [I18nBehavior],
properties: {
/** Whether or not the proxy values can be edited. */
editable: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment