Policy Webui: notify invalidations are available with 'On push' label

Bug: 933791
Change-Id: I987b1e0732d208c54bcfd0434408f1f0c4bad6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497334Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637984}

chrome/browser/resources/policy/policy.html

@@ -101,6 +101,10 @@
         <div class="label">$i18n{labelRefreshInterval}</div>
         <div class="refresh-interval"></div>
       </div>
+      <div class="status-entry">
+        <div class="label">$i18n{labelPoliciesPush}</div>
+        <div class="policy-push"></div>
+      </div>
       <div class="status-entry">
         <div class="label">$i18n{labelStatus}</div>
         <div class="status"></div>

chrome/browser/resources/policy/policy_base.js

@@ -149,6 +149,11 @@ cr.define('policy', function() {
           '.time-since-last-refresh', status.timeSinceLastRefresh, false);
       this.setLabelAndShow_('.refresh-interval', status.refreshInterval, false);
       this.setLabelAndShow_('.status', status.status, false);
+      this.setLabelAndShow_(
+          '.policy-push',
+          loadTimeData.getString(
+              status.policiesPushAvailable ? 'policiesPushOn' :
+                                             'policiesPushOff'));
     },
   };
 

chrome/browser/ui/webui/policy_ui.cc

@@ -52,6 +52,10 @@ content::WebUIDataSource* CreatePolicyUIHtmlSource() {
   source->AddLocalizedString("labelRefreshInterval",
                              IDS_POLICY_LABEL_REFRESH_INTERVAL);
   source->AddLocalizedString("labelStatus", IDS_POLICY_LABEL_STATUS);
+  source->AddLocalizedString("labelPoliciesPush",
+                             IDS_POLICY_LABEL_PUSH_POLICIES);
+  source->AddLocalizedString("policiesPushOn", IDS_POLICY_PUSH_POLICIES_ON);
+  source->AddLocalizedString("policiesPushOff", IDS_POLICY_PUSH_POLICIES_OFF);
   source->AddLocalizedString("showUnset", IDS_POLICY_SHOW_UNSET);
   source->AddLocalizedString("noPoliciesSet", IDS_POLICY_NO_POLICIES_SET);
   source->AddLocalizedString("showMore", IDS_POLICY_SHOW_MORE);

chrome/browser/ui/webui/policy_ui_handler.cc

@@ -150,6 +150,8 @@ void GetStatusFromCore(const policy::CloudPolicyCore* core,
   bool no_error = store->status() == policy::CloudPolicyStore::STATUS_OK &&
                   client && client->status() == policy::DM_STATUS_SUCCESS;
   dict->SetBoolean("error", !no_error);
+  dict->SetBoolean("policiesPushAvailable",
+                   refresh_scheduler->invalidations_available());
   dict->SetString("status", status);
   dict->SetString("clientId", client_id);
   dict->SetString("username", username);

components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

@@ -74,9 +74,7 @@ class POLICY_EXPORT CloudPolicyRefreshScheduler
 
   // Whether the invalidations service is available and receiving notifications
   // of policy updates.
-  bool invalidations_available() {
-    return invalidations_available_;
-  }
+  bool invalidations_available() const { return invalidations_available_; }
 
   // CloudPolicyClient::Observer:
   void OnPolicyFetched(CloudPolicyClient* client) override;

components/policy_strings.grdp

@@ -313,6 +313,15 @@ Additional details:
   <message name="IDS_POLICY_NOT_SPECIFIED" desc="Indicates if that device attribute has not specified yet.">
     Not Specified
   </message>
+  <message name="IDS_POLICY_LABEL_PUSH_POLICIES" desc="Label to indicates the policies can be pushed or not to chrome.">
+    Policies push:
+  </message>
+  <message name="IDS_POLICY_PUSH_POLICIES_ON" desc="Indicates the policies can be pushed to chrome.">
+    On
+  </message>
+  <message name="IDS_POLICY_PUSH_POLICIES_OFF" desc="Indicates the policies cannot be pushed to chrome.">
+    Off
+  </message>
   <message name="IDS_POLICY_NEVER_FETCHED" desc="Indicates that a policy fetch was never performed before.">
     Never
   </message>