Commit aefd0f63 authored by vogelheim's avatar vogelheim Committed by Commit bot

Re-enable tests under mac-asan.

I never quite found what the original issues were, but apparently they've been fixed in the mean time.

Revert "Disable faiilng tests under mac/asan"
This reverts commit 6585cde1.

BUG=

Review-Url: https://codereview.chromium.org/2364593002
Cr-Commit-Position: refs/heads/master@{#420606}
parent 1abe938f
......@@ -109,13 +109,7 @@ private:
bool m_finished;
};
#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
// TODO(marja): Fix this test, http://crbug.com/572987
#define MAYBE_CompilingStreamedScript DISABLED_CompilingStreamedScript
#else
#define MAYBE_CompilingStreamedScript CompilingStreamedScript
#endif
TEST_F(ScriptStreamingTest, MAYBE_CompilingStreamedScript)
TEST_F(ScriptStreamingTest, CompilingStreamedScript)
{
// Test that we can successfully compile a streamed script.
V8TestingScope scope;
......@@ -284,13 +278,7 @@ TEST_F(ScriptStreamingTest, SmallScripts)
EXPECT_FALSE(sourceCode.streamer());
}
#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
// TODO(marja): Fix this test, http://crbug.com/572987
#define MAYBE_ScriptsWithSmallFirstChunk DISABLED_ScriptsWithSmallFirstChunk
#else
#define MAYBE_ScriptsWithSmallFirstChunk ScriptsWithSmallFirstChunk
#endif
TEST_F(ScriptStreamingTest, MAYBE_ScriptsWithSmallFirstChunk)
TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk)
{
// If a script is long enough, if should be streamed, even if the first data
// chunk is small.
......@@ -321,13 +309,7 @@ TEST_F(ScriptStreamingTest, MAYBE_ScriptsWithSmallFirstChunk)
EXPECT_FALSE(tryCatch.HasCaught());
}
#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
// TODO(marja): Fix this test, http://crbug.com/572987
#define MAYBE_EncodingChanges DISABLED_EncodingChanges
#else
#define MAYBE_EncodingChanges EncodingChanges
#endif
TEST_F(ScriptStreamingTest, MAYBE_EncodingChanges)
TEST_F(ScriptStreamingTest, EncodingChanges)
{
// It's possible that the encoding of the Resource changes after we start
// loading it.
......@@ -357,13 +339,7 @@ TEST_F(ScriptStreamingTest, MAYBE_EncodingChanges)
}
#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
// TODO(marja): Fix this test, http://crbug.com/572987
#define MAYBE_EncodingFromBOM DISABLED_EncodingFromBOM
#else
#define MAYBE_EncodingFromBOM EncodingFromBOM
#endif
TEST_F(ScriptStreamingTest, MAYBE_EncodingFromBOM)
TEST_F(ScriptStreamingTest, EncodingFromBOM)
{
// Byte order marks should be removed before giving the data to V8. They
// will also affect encoding detection.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment