Commit af05b2a5 authored by nick's avatar nick Committed by Commit bot

Update {virtual,override} to follow C++11 style in content/renderer/media.

This CL has just two files which got some extra "while I'm in there" cleanup while doing mechanical fixups across the codebase.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

BUG=417463

Review URL: https://codereview.chromium.org/1106043002

Cr-Commit-Position: refs/heads/master@{#326972}
parent 8cbea05b
...@@ -25,61 +25,55 @@ class MockPeerConnectionImpl : public webrtc::PeerConnectionInterface { ...@@ -25,61 +25,55 @@ class MockPeerConnectionImpl : public webrtc::PeerConnectionInterface {
webrtc::PeerConnectionObserver* observer); webrtc::PeerConnectionObserver* observer);
// PeerConnectionInterface implementation. // PeerConnectionInterface implementation.
virtual rtc::scoped_refptr<webrtc::StreamCollectionInterface> rtc::scoped_refptr<webrtc::StreamCollectionInterface>
local_streams() override; local_streams() override;
virtual rtc::scoped_refptr<webrtc::StreamCollectionInterface> rtc::scoped_refptr<webrtc::StreamCollectionInterface>
remote_streams() override; remote_streams() override;
virtual bool AddStream( bool AddStream(
webrtc::MediaStreamInterface* local_stream) override; webrtc::MediaStreamInterface* local_stream) override;
virtual void RemoveStream( void RemoveStream(
webrtc::MediaStreamInterface* local_stream) override; webrtc::MediaStreamInterface* local_stream) override;
virtual rtc::scoped_refptr<webrtc::DtmfSenderInterface> rtc::scoped_refptr<webrtc::DtmfSenderInterface>
CreateDtmfSender(webrtc::AudioTrackInterface* track) override; CreateDtmfSender(webrtc::AudioTrackInterface* track) override;
virtual rtc::scoped_refptr<webrtc::DataChannelInterface> rtc::scoped_refptr<webrtc::DataChannelInterface>
CreateDataChannel(const std::string& label, CreateDataChannel(const std::string& label,
const webrtc::DataChannelInit* config) override; const webrtc::DataChannelInit* config) override;
bool GetStats(webrtc::StatsObserver* observer,
virtual bool GetStats(webrtc::StatsObserver* observer, webrtc::MediaStreamTrackInterface* track,
webrtc::MediaStreamTrackInterface* track) { StatsOutputLevel level) override;
return false;
}
virtual bool GetStats(webrtc::StatsObserver* observer,
webrtc::MediaStreamTrackInterface* track,
StatsOutputLevel level) override;
// Set Call this function to make sure next call to GetStats fail. // Set Call this function to make sure next call to GetStats fail.
void SetGetStatsResult(bool result) { getstats_result_ = result; } void SetGetStatsResult(bool result) { getstats_result_ = result; }
virtual SignalingState signaling_state() override { SignalingState signaling_state() override {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
return PeerConnectionInterface::kStable; return PeerConnectionInterface::kStable;
} }
virtual IceState ice_state() override { IceState ice_state() override {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
return PeerConnectionInterface::kIceNew; return PeerConnectionInterface::kIceNew;
} }
virtual IceConnectionState ice_connection_state() override { IceConnectionState ice_connection_state() override {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
return PeerConnectionInterface::kIceConnectionNew; return PeerConnectionInterface::kIceConnectionNew;
} }
virtual IceGatheringState ice_gathering_state() override { IceGatheringState ice_gathering_state() override {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
return PeerConnectionInterface::kIceGatheringNew; return PeerConnectionInterface::kIceGatheringNew;
} }
virtual void Close() override { void Close() override {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
} }
virtual const webrtc::SessionDescriptionInterface* local_description() const webrtc::SessionDescriptionInterface* local_description() const override;
const override; const webrtc::SessionDescriptionInterface* remote_description()
virtual const webrtc::SessionDescriptionInterface* remote_description()
const override; const override;
// JSEP01 APIs // JSEP01 APIs
virtual void CreateOffer( void CreateOffer(
webrtc::CreateSessionDescriptionObserver* observer, webrtc::CreateSessionDescriptionObserver* observer,
const webrtc::MediaConstraintsInterface* constraints) override; const webrtc::MediaConstraintsInterface* constraints) override;
virtual void CreateAnswer( void CreateAnswer(
webrtc::CreateSessionDescriptionObserver* observer, webrtc::CreateSessionDescriptionObserver* observer,
const webrtc::MediaConstraintsInterface* constraints) override; const webrtc::MediaConstraintsInterface* constraints) override;
MOCK_METHOD2(SetLocalDescription, MOCK_METHOD2(SetLocalDescription,
...@@ -94,12 +88,10 @@ class MockPeerConnectionImpl : public webrtc::PeerConnectionInterface { ...@@ -94,12 +88,10 @@ class MockPeerConnectionImpl : public webrtc::PeerConnectionInterface {
void SetRemoteDescriptionWorker( void SetRemoteDescriptionWorker(
webrtc::SetSessionDescriptionObserver* observer, webrtc::SetSessionDescriptionObserver* observer,
webrtc::SessionDescriptionInterface* desc); webrtc::SessionDescriptionInterface* desc);
virtual bool UpdateIce( bool UpdateIce(const IceServers& configuration,
const IceServers& configuration, const webrtc::MediaConstraintsInterface* constraints) override;
const webrtc::MediaConstraintsInterface* constraints) override; bool AddIceCandidate(const webrtc::IceCandidateInterface* candidate) override;
virtual bool AddIceCandidate( void RegisterUMAObserver(webrtc::UMAObserver* observer) override;
const webrtc::IceCandidateInterface* candidate) override;
virtual void RegisterUMAObserver(webrtc::UMAObserver* observer) override;
void AddRemoteStream(webrtc::MediaStreamInterface* stream); void AddRemoteStream(webrtc::MediaStreamInterface* stream);
......
...@@ -37,26 +37,24 @@ class CONTENT_EXPORT RtcDataChannelHandler ...@@ -37,26 +37,24 @@ class CONTENT_EXPORT RtcDataChannelHandler
RtcDataChannelHandler( RtcDataChannelHandler(
const scoped_refptr<base::SingleThreadTaskRunner>& main_thread, const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
webrtc::DataChannelInterface* channel); webrtc::DataChannelInterface* channel);
virtual ~RtcDataChannelHandler(); ~RtcDataChannelHandler() override;
// blink::WebRTCDataChannelHandler implementation. // blink::WebRTCDataChannelHandler implementation.
virtual void setClient( void setClient(
blink::WebRTCDataChannelHandlerClient* client) override; blink::WebRTCDataChannelHandlerClient* client) override;
virtual blink::WebString label() override; blink::WebString label() override;
virtual bool isReliable() override; bool isReliable() override;
virtual bool ordered() const override; bool ordered() const override;
virtual unsigned short maxRetransmitTime() const override; unsigned short maxRetransmitTime() const override;
virtual unsigned short maxRetransmits() const override; unsigned short maxRetransmits() const override;
virtual blink::WebString protocol() const override; blink::WebString protocol() const override;
virtual bool negotiated() const override; bool negotiated() const override;
virtual unsigned short id() const override; unsigned short id() const override;
// TODO(bemasc): Mark |state()| as |override| once https://codereview.chromium.org/782843003/ blink::WebRTCDataChannelHandlerClient::ReadyState state() const override;
// lands in Blink and rolls into Chromium. unsigned long bufferedAmount() override;
virtual blink::WebRTCDataChannelHandlerClient::ReadyState state() const; bool sendStringData(const blink::WebString& data) override;
virtual unsigned long bufferedAmount() override; bool sendRawData(const char* data, size_t length) override;
virtual bool sendStringData(const blink::WebString& data) override; void close() override;
virtual bool sendRawData(const char* data, size_t length) override;
virtual void close() override;
const scoped_refptr<webrtc::DataChannelInterface>& channel() const; const scoped_refptr<webrtc::DataChannelInterface>& channel() const;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment