Commit af1e70e1 authored by yoav@yoav.ws's avatar yoav@yoav.ws

Remove the srcset Runtime Enabled Flag

BUG=363039

Review URL: https://codereview.chromium.org/236753003

git-svn-id: svn://svn.chromium.org/blink/trunk@171490 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent cfac132a
......@@ -154,16 +154,14 @@ void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr
if (renderer() && renderer()->isImage())
toRenderImage(renderer())->updateAltText();
} else if (name == srcAttr || name == srcsetAttr) {
if (RuntimeEnabledFeatures::srcsetEnabled()) {
int effectiveSize = -1; // FIXME - hook up the real value from `sizes`
ImageCandidate candidate = bestFitSourceForImageAttributes(document().devicePixelRatio(), effectiveSize, fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
m_bestFitImageURL = candidate.toAtomicString();
float candidateScaleFactor = candidate.scaleFactor();
if (candidateScaleFactor > 0)
m_imageDevicePixelRatio = 1 / candidateScaleFactor;
if (renderer() && renderer()->isImage())
toRenderImage(renderer())->setImageDevicePixelRatio(m_imageDevicePixelRatio);
}
int effectiveSize = -1; // FIXME - hook up the real value from `sizes`
ImageCandidate candidate = bestFitSourceForImageAttributes(document().devicePixelRatio(), effectiveSize, fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
m_bestFitImageURL = candidate.toAtomicString();
float candidateScaleFactor = candidate.scaleFactor();
if (candidateScaleFactor > 0)
m_imageDevicePixelRatio = 1 / candidateScaleFactor;
if (renderer() && renderer()->isImage())
toRenderImage(renderer())->setImageDevicePixelRatio(m_imageDevicePixelRatio);
m_imageLoader.updateFromElementIgnoringPreviousError();
} else if (name == usemapAttr) {
setIsLink(!value.isNull());
......
......@@ -37,7 +37,7 @@
readonly attribute long naturalHeight;
readonly attribute long naturalWidth;
[Reflect, URL, PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds] attribute DOMString src;
[Reflect, RuntimeEnabled=Srcset] attribute DOMString srcset;
[Reflect] attribute DOMString srcset;
[Reflect] attribute DOMString useMap;
[Reflect] attribute long vspace;
attribute long width;
......
......@@ -177,9 +177,7 @@ private:
setUrlToLoad(bestFitSourceForImageAttributes(m_mediaValues->devicePixelRatio(), effectiveSize, attributeValue, m_srcsetImageCandidate), AllowURLReplacement);
} else if (match(attributeName, crossoriginAttr)) {
setCrossOriginAllowed(attributeValue);
} else if (RuntimeEnabledFeatures::srcsetEnabled()
&& match(attributeName, srcsetAttr)
&& m_srcsetImageCandidate.isEmpty()) {
} else if (match(attributeName, srcsetAttr) && m_srcsetImageCandidate.isEmpty()) {
m_srcsetImageCandidate = bestFitSourceForSrcsetAttribute(m_mediaValues->devicePixelRatio(), effectiveSize, attributeValue);
setUrlToLoad(bestFitSourceForImageAttributes(m_mediaValues->devicePixelRatio(), effectiveSize, m_urlToLoad, m_srcsetImageCandidate), AllowURLReplacement);
}
......
......@@ -108,7 +108,6 @@ SharedWorker status=stable
PictureSizes status=experimental
SpeechInput status=test
SpeechSynthesis status=stable
Srcset status=stable
Stream status=experimental
StyleScoped status=experimental
SubpixelFontScaling status=experimental
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment