Skip to content

GitLab

T
tangled
Commit af203e12 authored by Yashar Dabiran's avatar Yashar Dabiran Committed by Commit Bot
Browse files
Options

[5 of 5] Change OriginTrialEnabled to RuntimeEnabled for the added tests 

This CL is part of the efforts to add |RuntimeEnabled| IDL attribute
support for origin trial features.

Design doc for the overall change:
https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q

* bindings test expectations should not change with this CL

Bug: 934451
Change-Id: Id8d8bc718b0c8d19c9e30f794e2d351ffb82206b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558688
Commit-Queue: Yashar Dabiran <yashard@google.com>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649851}
parent 3b8760a3
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 8 deletions
third_party/blink/renderer/bindings/tests/idls/core/test_constants.idl
View file @ af203e12
...@@ -35,9 +35,9 @@ interface TestConstants { ...@@ -35,9 +35,9 @@ interface TestConstants {
[OriginTrialEnabled=FeatureName1] const short FEATURE1_ORIGIN_TRIAL_ENABLED_CONST2 = 7; [OriginTrialEnabled=FeatureName1] const short FEATURE1_ORIGIN_TRIAL_ENABLED_CONST2 = 7;
[OriginTrialEnabled=FeatureName2] const short FEATURE2_ORIGIN_TRIAL_ENABLED_CONST1 = 8; [OriginTrialEnabled=FeatureName2] const short FEATURE2_ORIGIN_TRIAL_ENABLED_CONST1 = 8;
[OriginTrialEnabled=FeatureName2] const short FEATURE2_ORIGIN_TRIAL_ENABLED_CONST2 = 9; [OriginTrialEnabled=FeatureName2] const short FEATURE2_ORIGIN_TRIAL_ENABLED_CONST2 = 9;
[OriginTrialEnabled=OriginTrialFeature1] const short FEATURE3_ORIGIN_TRIAL_ENABLED_CONST1 = 10; [RuntimeEnabled=OriginTrialFeature1] const short FEATURE3_ORIGIN_TRIAL_ENABLED_CONST1 = 10;
[OriginTrialEnabled=OriginTrialFeature1] const short FEATURE3_ORIGIN_TRIAL_ENABLED_CONST2 = 11; [RuntimeEnabled=OriginTrialFeature1] const short FEATURE3_ORIGIN_TRIAL_ENABLED_CONST2 = 11;
[OriginTrialEnabled=OriginTrialFeature2] const short FEATURE4_ORIGIN_TRIAL_ENABLED_CONST1 = 12; [RuntimeEnabled=OriginTrialFeature2] const short FEATURE4_ORIGIN_TRIAL_ENABLED_CONST1 = 12;
[OriginTrialEnabled=OriginTrialFeature2] const short FEATURE4_ORIGIN_TRIAL_ENABLED_CONST2 = 13; [RuntimeEnabled=OriginTrialFeature2] const short FEATURE4_ORIGIN_TRIAL_ENABLED_CONST2 = 13;
[Reflect=CONST_IMPL] const short CONST_JAVASCRIPT = 1; [Reflect=CONST_IMPL] const short CONST_JAVASCRIPT = 1;
}; };
third_party/blink/renderer/bindings/tests/idls/core/test_dictionary.idl
View file @ af203e12
...@@ -41,8 +41,8 @@ dictionary TestDictionary { ...@@ -41,8 +41,8 @@ dictionary TestDictionary {
[RuntimeEnabled=RuntimeFeature] boolean runtimeSecondMember; [RuntimeEnabled=RuntimeFeature] boolean runtimeSecondMember;
[OriginTrialEnabled=FeatureName] boolean originTrialMember; [OriginTrialEnabled=FeatureName] boolean originTrialMember;
[OriginTrialEnabled=FeatureName1] boolean originTrialSecondMember; [OriginTrialEnabled=FeatureName1] boolean originTrialSecondMember;
[OriginTrialEnabled=OriginTrialFeature] boolean originTrialThirdMember; [RuntimeEnabled=OriginTrialFeature] boolean originTrialThirdMember;
[OriginTrialEnabled=OriginTrialFeature1] boolean originTrialFourthMember; [RuntimeEnabled=OriginTrialFeature1] boolean originTrialFourthMember;
record<ByteString, byte> recordMember; record<ByteString, byte> recordMember;
record<USVString, TestObject> garbageCollectedRecordMember; record<USVString, TestObject> garbageCollectedRecordMember;
record<ByteString, (long or boolean)> unionInRecordMember; record<ByteString, (long or boolean)> unionInRecordMember;
......
third_party/blink/renderer/bindings/tests/idls/core/test_interface.idl
View file @ af203e12
...@@ -91,7 +91,7 @@ ...@@ -91,7 +91,7 @@
[Exposed=Worker] void workerExposedMethod(); [Exposed=Worker] void workerExposedMethod();
[Exposed=Window] void windowExposedMethod(); [Exposed=Window] void windowExposedMethod();
[Exposed=Window,OriginTrialEnabled=TestFeature] void originTrialWindowExposedMethod(); [Exposed=Window,OriginTrialEnabled=TestFeature] void originTrialWindowExposedMethod();
[Exposed=Window,OriginTrialEnabled=OriginTrialFeature] void originTrialWindowExposedMethod2(); [Exposed=Window,RuntimeEnabled=OriginTrialFeature] void originTrialWindowExposedMethod2();
static void alwaysExposedStaticMethod(); static void alwaysExposedStaticMethod();
[Exposed=Worker] static void workerExposedStaticMethod(); [Exposed=Worker] static void workerExposedStaticMethod();
......
third_party/blink/renderer/bindings/tests/idls/core/test_object.idl
View file @ af203e12
...@@ -157,7 +157,7 @@ interface TestObject { ...@@ -157,7 +157,7 @@ interface TestObject {
[MeasureAs=TestFeature] attribute long measureAsLongAttribute; [MeasureAs=TestFeature] attribute long measureAsLongAttribute;
[NotEnumerable] attribute long notEnumerableLongAttribute; [NotEnumerable] attribute long notEnumerableLongAttribute;
[OriginTrialEnabled=FeatureName] attribute long originTrialEnabledLongAttribute; [OriginTrialEnabled=FeatureName] attribute long originTrialEnabledLongAttribute;
[OriginTrialEnabled=OriginTrialFeature] attribute long originTrialEnabledLongAttribute2; [RuntimeEnabled=OriginTrialFeature] attribute long originTrialEnabledLongAttribute2;
[PerWorldBindings] readonly attribute TestInterfaceEmpty perWorldBindingsReadonlyTestInterfaceEmptyAttribute; [PerWorldBindings] readonly attribute TestInterfaceEmpty perWorldBindingsReadonlyTestInterfaceEmptyAttribute;
[LogActivity, LogAllWorlds, PerWorldBindings] attribute long activityLoggingAccessPerWorldBindingsLongAttribute; [LogActivity, LogAllWorlds, PerWorldBindings] attribute long activityLoggingAccessPerWorldBindingsLongAttribute;
[LogActivity, PerWorldBindings] attribute long activityLoggingAccessForIsolatedWorldsPerWorldBindingsLongAttribute; [LogActivity, PerWorldBindings] attribute long activityLoggingAccessForIsolatedWorldsPerWorldBindingsLongAttribute;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment