[Autofill] Use TestPatternProvider in unit tests.

This CL fixes several unit tests that use the PatternProvider.

Tbr: koerber@google.com
Change-Id: Ia809f85015601a3fe8147209ea8c073875a50935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489081Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#819308}

components/autofill/core/browser/form_parsing/address_field_unittest.cc

@@ -14,6 +14,7 @@
 #include "base/test/scoped_feature_list.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/autofill_features.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -24,13 +25,11 @@ namespace autofill {
 
 class AddressFieldTest : public testing::Test {
  public:
-  AddressFieldTest() {}
+  AddressFieldTest() = default;
+  AddressFieldTest(const AddressFieldTest&) = delete;
+  AddressFieldTest& operator=(const AddressFieldTest&) = delete;
 
  protected:
-  std::vector<std::unique_ptr<AutofillField>> list_;
-  std::unique_ptr<AddressField> field_;
-  FieldCandidatesMap field_candidates_map_;
-
   // Downcast for tests.
   static std::unique_ptr<AddressField> Parse(AutofillScanner* scanner) {
     // An empty page_language means the language is unknown and patterns of all
@@ -41,8 +40,12 @@ class AddressFieldTest : public testing::Test {
         static_cast<AddressField*>(field.release()));
   }
 
- private:
-  DISALLOW_COPY_AND_ASSIGN(AddressFieldTest);
+  std::vector<std::unique_ptr<AutofillField>> list_;
+  std::unique_ptr<AddressField> field_;
+  FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 TEST_F(AddressFieldTest, Empty) {

components/autofill/core/browser/form_parsing/credit_card_field_unittest.cc

@@ -13,6 +13,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/autofill_clock.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -23,14 +24,11 @@ namespace autofill {
 
 class CreditCardFieldTestBase {
  public:
-  CreditCardFieldTestBase() {}
-  ~CreditCardFieldTestBase() {}
+  CreditCardFieldTestBase() = default;
+  CreditCardFieldTestBase(const CreditCardFieldTestBase&) = delete;
+  CreditCardFieldTestBase& operator=(const CreditCardFieldTestBase&) = delete;
 
  protected:
-  std::vector<std::unique_ptr<AutofillField>> list_;
-  std::unique_ptr<const CreditCardField> field_;
-  FieldCandidatesMap field_candidates_map_;
-
   // Parses the contents of |list_| as a form, and stores the result into
   // |field_|.
   void Parse() {
@@ -67,17 +65,20 @@ class CreditCardFieldTestBase {
     return field_->AddClassifications(&field_candidates_map_);
   }
 
- private:
-  DISALLOW_COPY_AND_ASSIGN(CreditCardFieldTestBase);
+  std::vector<std::unique_ptr<AutofillField>> list_;
+  std::unique_ptr<const CreditCardField> field_;
+  FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 class CreditCardFieldTest : public CreditCardFieldTestBase,
                             public testing::Test {
  public:
-  CreditCardFieldTest() {}
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(CreditCardFieldTest);
+  CreditCardFieldTest() = default;
+  CreditCardFieldTest(const CreditCardFieldTest&) = delete;
+  CreditCardFieldTest& operator=(const CreditCardFieldTest&) = delete;
 };
 
 TEST_F(CreditCardFieldTest, Empty) {

components/autofill/core/browser/form_parsing/name_field_unittest.cc

@@ -13,6 +13,7 @@
 #include "base/test/scoped_feature_list.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/autofill_features.h"
 #include "components/autofill/core/common/autofill_regex_constants.h"
 #include "components/autofill/core/common/autofill_regexes.h"
@@ -25,13 +26,11 @@ namespace autofill {
 
 class NameFieldTest : public testing::Test {
  public:
-  NameFieldTest() {}
+  NameFieldTest() = default;
+  NameFieldTest(const NameFieldTest&) = delete;
+  NameFieldTest& operator=(const NameFieldTest&) = delete;
 
  protected:
-  std::vector<std::unique_ptr<AutofillField>> list_;
-  std::unique_ptr<NameField> field_;
-  FieldCandidatesMap field_candidates_map_;
-
   // Downcast for tests.
   static std::unique_ptr<NameField> Parse(AutofillScanner* scanner) {
     // An empty page_language means the language is unknown and patterns of all
@@ -41,8 +40,12 @@ class NameFieldTest : public testing::Test {
     return std::unique_ptr<NameField>(static_cast<NameField*>(field.release()));
   }
 
- private:
-  DISALLOW_COPY_AND_ASSIGN(NameFieldTest);
+  std::vector<std::unique_ptr<AutofillField>> list_;
+  std::unique_ptr<NameField> field_;
+  FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 TEST_F(NameFieldTest, FirstMiddleLast) {

components/autofill/core/browser/form_parsing/phone_field_unittest.cc

@@ -16,6 +16,7 @@
 #include "base/test/scoped_feature_list.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/autofill_features.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -83,6 +84,9 @@ class PhoneFieldTest : public testing::Test {
   std::vector<std::unique_ptr<AutofillField>> list_;
   std::unique_ptr<PhoneField> field_;
   FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 TEST_F(PhoneFieldTest, Empty) {

components/autofill/core/browser/form_parsing/price_field_unittest.cc

@@ -13,6 +13,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -22,13 +23,11 @@ namespace autofill {
 
 class PriceFieldTest : public testing::Test {
  public:
-  PriceFieldTest() {}
+  PriceFieldTest() = default;
+  PriceFieldTest(const PriceFieldTest&) = delete;
+  PriceFieldTest& operator=(const PriceFieldTest&) = delete;
 
  protected:
-  std::vector<std::unique_ptr<AutofillField>> list_;
-  std::unique_ptr<PriceField> field_;
-  FieldCandidatesMap field_candidates_map_;
-
   // Downcast for tests.
   static std::unique_ptr<PriceField> Parse(AutofillScanner* scanner) {
     // An empty page_language means the language is unknown and patterns of all
@@ -39,8 +38,12 @@ class PriceFieldTest : public testing::Test {
         static_cast<PriceField*>(field.release()));
   }
 
- private:
-  DISALLOW_COPY_AND_ASSIGN(PriceFieldTest);
+  std::vector<std::unique_ptr<AutofillField>> list_;
+  std::unique_ptr<PriceField> field_;
+  FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 TEST_F(PriceFieldTest, ParsePrice) {

components/autofill/core/browser/form_parsing/search_field_unittest.cc

@@ -13,6 +13,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/form_parsing/autofill_scanner.h"
+#include "components/autofill/core/browser/pattern_provider/test_pattern_provider.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -22,13 +23,11 @@ namespace autofill {
 
 class SearchFieldTest : public testing::Test {
  public:
-  SearchFieldTest() {}
+  SearchFieldTest() = default;
+  SearchFieldTest(const SearchFieldTest&) = delete;
+  SearchFieldTest& operator=(const SearchFieldTest&) = delete;
 
  protected:
-  std::vector<std::unique_ptr<AutofillField>> list_;
-  std::unique_ptr<SearchField> field_;
-  FieldCandidatesMap field_candidates_map_;
-
   // Downcast for tests.
   static std::unique_ptr<SearchField> Parse(AutofillScanner* scanner) {
     // An empty page_language means the language is unknown and patterns of all
@@ -39,8 +38,12 @@ class SearchFieldTest : public testing::Test {
         static_cast<SearchField*>(field.release()));
   }
 
- private:
-  DISALLOW_COPY_AND_ASSIGN(SearchFieldTest);
+  std::vector<std::unique_ptr<AutofillField>> list_;
+  std::unique_ptr<SearchField> field_;
+  FieldCandidatesMap field_candidates_map_;
+
+  // RAII object to mock the the PatternProvider.
+  TestPatternProvider test_pattern_provider_;
 };
 
 TEST_F(SearchFieldTest, ParseSearchTerm) {