Commit af428822 authored by danakj's avatar danakj Committed by Commit Bot

Remove outdated comment and TODO in RenderFrameImpl about main frames

Main frame RenderWidgets are now owned by RenderFrameImpl just like
child frames' are.

R=dcheng@chromium.org, haraken@chromium.org

Bug: 419087
Change-Id: I4f02f1b4c71299cc2f37f9249b3cc84b3662ed11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038720Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738590}
parent 6259653d
...@@ -1457,7 +1457,7 @@ void RenderFrameImpl::CreateFrame( ...@@ -1457,7 +1457,7 @@ void RenderFrameImpl::CreateFrame(
bool has_committed_real_load) { bool has_committed_real_load) {
// TODO(danakj): Split this method into two pieces. The first block makes a // TODO(danakj): Split this method into two pieces. The first block makes a
// WebLocalFrame and collects the RenderView and RenderFrame for it. The // WebLocalFrame and collects the RenderView and RenderFrame for it. The
// second block uses that to make/setup a RenderWidget, if needed. // second block uses that to make a RenderWidget, if needed.
RenderViewImpl* render_view = nullptr; RenderViewImpl* render_view = nullptr;
RenderFrameImpl* render_frame = nullptr; RenderFrameImpl* render_frame = nullptr;
blink::WebLocalFrame* web_frame = nullptr; blink::WebLocalFrame* web_frame = nullptr;
...@@ -1549,17 +1549,11 @@ void RenderFrameImpl::CreateFrame( ...@@ -1549,17 +1549,11 @@ void RenderFrameImpl::CreateFrame(
if (!is_main_frame) if (!is_main_frame)
DCHECK_NE(parent_routing_id, MSG_ROUTING_NONE); DCHECK_NE(parent_routing_id, MSG_ROUTING_NONE);
// We now have a WebLocalFrame for the new frame. The next step is to set // We now have a WebLocalFrame for the new frame. The next step is to make
// up a RenderWidget for it, if it is needed. // a RenderWidget (aka WebWidgetClient) for it, if it is a local root.
if (is_main_frame) { if (is_main_frame) {
// Main frames are always local roots, so they should always have a // Main frames are always local roots, so they should always have a
// |widget_params| (and it always comes with a routing id). Surprisingly, // |widget_params| (and it always comes with a routing id).
// this routing id is *not* used though, as the routing id on the existing
// RenderWidget is not changed (since the RenderWidgetHost objects are not
// destroyed along with the RenderWidget if the RenderView is kept alive).
// TODO(crbug.com/888105): It's a bug that the RenderWidget is not using
// this routing id, but it should be the same routing id at the moment
// anyway.
DCHECK(widget_params); DCHECK(widget_params);
DCHECK_NE(widget_params->routing_id, MSG_ROUTING_NONE); DCHECK_NE(widget_params->routing_id, MSG_ROUTING_NONE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment