Commit af6af7e3 authored by Reid Kleckner's avatar Reid Kleckner Committed by Commit Bot

Disable death test in official builds, it fails there

This death test is looking for output from a CHECK failure, and CHECk
failures are not printed in official+release builds.

This test has been failing on our official clang ToT bot since it was
added: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2132

R=dougarnett@chromium.org,jam@chromium.org

Bug: 864640
Change-Id: I7527d65d3ffcfba9a68427aa60d2e6152be838ce
Reviewed-on: https://chromium-review.googlesource.com/1217066Reviewed-by: default avatarDoug Arnett <dougarnett@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590041}
parent 7fc8a7a3
......@@ -101,7 +101,8 @@ TEST(BloomFilterTest, EverythingMatches) {
EXPECT_TRUE(filter.Contains("Echo"));
}
#if !defined(OS_IOS)
// Disable this test in configurations that don't print CHECK failures.
#if !defined(OS_IOS) && !(defined(OFFICIAL_BUILD) && defined(NDEBUG))
TEST(BloomFilterTest, ByteVectorTooSmall) {
ByteVector data(1023, 0xff);
EXPECT_DEATH({ BloomFilter filter(8191 /* num_bits */, data, 7); },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment