Move sandbox manifest unittests from chrome/ to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2571123002
Cr-Commit-Position: refs/heads/master@{#438632}

chrome/test/BUILD.gn

@@ -4048,7 +4048,6 @@ test("unit_tests") {
       "../common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc",
       "../common/extensions/manifest_tests/extension_manifests_portsinpermissions_unittest.cc",
       "../common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc",
-      "../common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc",
       "../common/extensions/manifest_tests/extension_manifests_storage_unittest.cc",
       "../common/extensions/manifest_tests/extension_manifests_ui_unittest.cc",
       "../common/extensions/manifest_tests/extension_manifests_update_unittest.cc",

extensions/common/BUILD.gn

@@ -319,6 +319,7 @@ if (enable_extensions) {
       "image_util_unittest.cc",
       "manifest_handler_unittest.cc",
       "manifest_handlers/content_capabilities_manifest_unittest.cc",
+      "manifest_handlers/csp_info_unittest.cc",
       "manifest_handlers/default_locale_manifest_unittest.cc",
       "manifest_handlers/externally_connectable_unittest.cc",
       "manifest_handlers/file_handler_manifest_unittest.cc",

chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc → extensions/common/manifest_handlers/csp_info_unittest.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/macros.h"
-#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handlers/csp_info.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "extensions/common/manifest_test.h"
 
 namespace extensions {
 
 namespace errors = manifest_errors;
 
-class SandboxedPagesManifestTest : public ChromeManifestTest {
-};
+using CSPInfoUnitTest = ManifestTest;
 
-TEST_F(SandboxedPagesManifestTest, SandboxedPages) {
+TEST_F(CSPInfoUnitTest, SandboxedPages) {
   // Sandboxed pages specified, no custom CSP value.
   scoped_refptr<Extension> extension1(
       LoadAndExpectSuccess("sandboxed_pages_valid_1.json"));
@@ -44,45 +41,34 @@ TEST_F(SandboxedPagesManifestTest, SandboxedPages) {
   const char kCustomSandboxedCSP[] =
       "sandbox; script-src: https://www.google.com";
 
-  EXPECT_EQ(
-      kSandboxedCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension1.get(), "/test"));
-  EXPECT_EQ(
-      kDefaultCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension1.get(), "/none"));
-  EXPECT_EQ(
-      kDefaultCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension2.get(), "/test"));
-  EXPECT_EQ(
-      kCustomSandboxedCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension3.get(), "/test"));
-  EXPECT_EQ(
-      kDefaultCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension3.get(), "/none"));
-  EXPECT_EQ(
-      kSandboxedCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension4.get(), "/test"));
-  EXPECT_EQ(kSandboxedCSP,
-            CSPInfo::GetResourceContentSecurityPolicy(extension5.get(),
-                                                      "/path/test.ext"));
-  EXPECT_EQ(
-      kDefaultCSP,
-      CSPInfo::GetResourceContentSecurityPolicy(extension5.get(), "/test"));
+  EXPECT_EQ(kSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                               extension1.get(), "/test"));
+  EXPECT_EQ(kDefaultCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                             extension1.get(), "/none"));
+  EXPECT_EQ(kDefaultCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                             extension2.get(), "/test"));
+  EXPECT_EQ(kCustomSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                                     extension3.get(), "/test"));
+  EXPECT_EQ(kDefaultCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                             extension3.get(), "/none"));
+  EXPECT_EQ(kSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                               extension4.get(), "/test"));
+  EXPECT_EQ(kSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                               extension5.get(), "/path/test.ext"));
+  EXPECT_EQ(kDefaultCSP, CSPInfo::GetResourceContentSecurityPolicy(
+                             extension5.get(), "/test"));
 
   Testcase testcases[] = {
-    Testcase("sandboxed_pages_invalid_1.json",
-        errors::kInvalidSandboxedPagesList),
-    Testcase("sandboxed_pages_invalid_2.json",
-        errors::kInvalidSandboxedPage),
-    Testcase("sandboxed_pages_invalid_3.json",
-        errors::kInvalidSandboxedPagesCSP),
-    Testcase("sandboxed_pages_invalid_4.json",
-        errors::kInvalidSandboxedPagesCSP),
-    Testcase("sandboxed_pages_invalid_5.json",
-        errors::kInvalidSandboxedPagesCSP)
-  };
-  RunTestcases(testcases, arraysize(testcases),
-               EXPECT_TYPE_ERROR);
+      Testcase("sandboxed_pages_invalid_1.json",
+               errors::kInvalidSandboxedPagesList),
+      Testcase("sandboxed_pages_invalid_2.json", errors::kInvalidSandboxedPage),
+      Testcase("sandboxed_pages_invalid_3.json",
+               errors::kInvalidSandboxedPagesCSP),
+      Testcase("sandboxed_pages_invalid_4.json",
+               errors::kInvalidSandboxedPagesCSP),
+      Testcase("sandboxed_pages_invalid_5.json",
+               errors::kInvalidSandboxedPagesCSP)};
+  RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
 }
 
 }  // namespace extensions