Commit af6d0254 authored by Muhamed Parić's avatar Muhamed Parić Committed by Commit Bot

Remove TODOs and debug logs since crbug.com/582506 is closed.

Bug: 988059
Change-Id: Ibd28b8060aa1efff383e689ffa3ee5437d0faf4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035950
Commit-Queue: Muhamed Parić <muhamedp@google.com>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737860}
parent b26cddc3
......@@ -8,7 +8,6 @@
#include "base/feature_list.h"
#include "base/logging.h"
#include "base/syslog_logging.h"
#include "chrome/browser/policy/cloud/policy_invalidation_util.h"
#include "chrome/common/chrome_features.h"
#include "components/invalidation/public/invalidation.h"
......@@ -30,8 +29,6 @@ void RemoteCommandsInvalidator::Initialize(
invalidation::InvalidationService* invalidation_service) {
DCHECK_EQ(SHUT_DOWN, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Initialize RemoteCommandsInvalidator.";
DCHECK(invalidation_service);
invalidation_service_ = invalidation_service;
......@@ -43,8 +40,6 @@ void RemoteCommandsInvalidator::Initialize(
void RemoteCommandsInvalidator::Shutdown() {
DCHECK_NE(SHUT_DOWN, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Shutdown RemoteCommandsInvalidator.";
Stop();
......@@ -55,8 +50,6 @@ void RemoteCommandsInvalidator::Shutdown() {
void RemoteCommandsInvalidator::Start() {
DCHECK_EQ(STOPPED, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Starting RemoteCommandsInvalidator.";
state_ = STARTED;
......@@ -66,8 +59,6 @@ void RemoteCommandsInvalidator::Start() {
void RemoteCommandsInvalidator::Stop() {
DCHECK_NE(SHUT_DOWN, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Stopping RemoteCommandsInvalidator.";
if (state_ == STARTED) {
Unregister();
......@@ -81,8 +72,6 @@ void RemoteCommandsInvalidator::OnInvalidatorStateChange(
syncer::InvalidatorState state) {
DCHECK_EQ(STARTED, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "RemoteCommandsInvalidator state changed: " << state;
invalidation_service_enabled_ = state == syncer::INVALIDATIONS_ENABLED;
UpdateInvalidationsEnabled();
......@@ -92,8 +81,6 @@ void RemoteCommandsInvalidator::OnIncomingInvalidation(
const syncer::ObjectIdInvalidationMap& invalidation_map) {
DCHECK_EQ(STARTED, state_);
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "RemoteCommandsInvalidator received invalidation.";
if (!invalidation_service_enabled_)
LOG(WARNING) << "Unexpected invalidation received.";
......@@ -108,8 +95,6 @@ void RemoteCommandsInvalidator::OnIncomingInvalidation(
// Acknowledge all invalidations.
for (const auto& it : list)
it.Acknowledge();
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Invalidations acknowledged.";
DoRemoteCommandsFetch();
}
......@@ -126,8 +111,6 @@ bool RemoteCommandsInvalidator::IsPublicTopic(
void RemoteCommandsInvalidator::ReloadPolicyData(
const enterprise_management::PolicyData* policy) {
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "RemoteCommandsInvalidator ReloadPolicyData.";
if (state_ != STARTED)
return;
......@@ -148,9 +131,6 @@ void RemoteCommandsInvalidator::ReloadPolicyData(
void RemoteCommandsInvalidator::Register(
const invalidation::ObjectId& object_id) {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Register RemoteCommandsInvalidator.";
// Register this handler with the invalidation service if needed.
if (!is_registered_) {
OnInvalidatorStateChange(invalidation_service_->GetInvalidatorState());
......@@ -168,8 +148,6 @@ void RemoteCommandsInvalidator::Register(
}
void RemoteCommandsInvalidator::Unregister() {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Unregister RemoteCommandsInvalidator.";
if (is_registered_) {
CHECK(invalidation_service_->UpdateRegisteredInvalidationIds(
this, syncer::ObjectIdSet()));
......
......@@ -36,16 +36,12 @@ RemoteCommandsService::~RemoteCommandsService() {
}
bool RemoteCommandsService::FetchRemoteCommands() {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Fetching remote commands.";
if (!client_->is_registered()) {
SYSLOG(WARNING) << "Client is not registered.";
return false;
}
if (command_fetch_in_progress_) {
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(WARNING) << "Command fetch is already in progress.";
has_enqueued_fetch_request_ = true;
return false;
}
......@@ -221,8 +217,6 @@ void RemoteCommandsService::OnRemoteCommandsFetched(
const std::vector<enterprise_management::RemoteCommand>& commands,
const std::vector<enterprise_management::SignedData>& signed_commands) {
DCHECK(command_fetch_in_progress_);
// TODO(hunyadym): Remove after crbug.com/582506 is fixed.
SYSLOG(INFO) << "Remote commands fetched.";
command_fetch_in_progress_ = false;
if (!on_command_acked_callback_.is_null())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment