Commit af808596 authored by Kuo Jen Wei's avatar Kuo Jen Wei Committed by Commit Bot

Fix CCA a11y read setting menu and mode selector text bug.

Change-Id: I869182973b24d09fb5477c0f01fc2bb6892d3288
Bug: 954561, 954564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574875Reviewed-by: default avatarSheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652817}
parent 1a4ddc17
...@@ -56,33 +56,33 @@ ...@@ -56,33 +56,33 @@
</div> </div>
</div> </div>
<div id="modes-group" class="buttons right-stripe"> <div id="modes-group" class="buttons right-stripe">
<label class="mode-item" tabindex="-1"> <label class="mode-item">
<input type="radio" name="mode" <input type="radio" name="mode"
data-mode="video-mode" tabindex="0" data-mode="video-mode" tabindex="0"
i18n-aria="switch_record_video_button"> i18n-aria="switch_record_video_button">
<span i18n-content="label_switch_record_video_button" <span i18n-content="label_switch_record_video_button"
tabindex="-1"></span> aria-hidden="true"></span>
</label> </label>
<label class="mode-item" tabindex="-1"> <label class="mode-item">
<input type="radio" name="mode" <input type="radio" name="mode"
data-mode="photo-mode" tabindex="0" data-mode="photo-mode" tabindex="0"
i18n-aria="switch_take_photo_button"> i18n-aria="switch_take_photo_button">
<span i18n-content="label_switch_take_photo_button" <span i18n-content="label_switch_take_photo_button"
tabindex="-1"></span> aria-hidden="true"></span>
</label> </label>
<label class="mode-item" tabindex="-1"> <label class="mode-item">
<input type="radio" name="mode" <input type="radio" name="mode"
data-mode="square-mode" tabindex="0" data-mode="square-mode" tabindex="0"
i18n-aria="switch_take_square_photo_button"> i18n-aria="switch_take_square_photo_button">
<span i18n-content="label_switch_take_square_photo_button" <span i18n-content="label_switch_take_square_photo_button"
tabindex="-1"></span> aria-hidden="true"></span>
</label> </label>
<label class="mode-item" tabindex="-1"> <label class="mode-item">
<input type="radio" name="mode" <input type="radio" name="mode"
data-mode="portrait-mode" tabindex="0" data-mode="portrait-mode" tabindex="0"
i18n-aria="switch_take_portrait_photo_button"> i18n-aria="switch_take_portrait_photo_button">
<span i18n-content="label_switch_take_portrait_photo_button" <span i18n-content="label_switch_take_portrait_photo_button"
tabindex="-1"></span> aria-hidden="true"></span>
</label> </label>
</div> </div>
<div id="shutters-group" class="buttons right-stripe circle"> <div id="shutters-group" class="buttons right-stripe circle">
...@@ -135,7 +135,7 @@ ...@@ -135,7 +135,7 @@
<div class="menu"> <div class="menu">
<div class="menu-header circle"> <div class="menu-header circle">
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div role="menu" i18n-content="settings_button"></div> <div i18n-content="settings_button"></div>
</div> </div>
<button class="menu-item circle" id="settings-gridtype" tabindex="0" <button class="menu-item circle" id="settings-gridtype" tabindex="0"
aria-describedby="gridtype-desc"> aria-describedby="gridtype-desc">
...@@ -176,7 +176,7 @@ ...@@ -176,7 +176,7 @@
<div class="menu"> <div class="menu">
<div class="menu-header circle"> <div class="menu-header circle">
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div role="menu" i18n-content="grid_type_button"></div> <div i18n-content="grid_type_button"></div>
</div> </div>
<label class="menu-item circle" for="grid-3x3"> <label class="menu-item circle" for="grid-3x3">
<input class="icon" id="grid-3x3" type="radio" tabindex="0" <input class="icon" id="grid-3x3" type="radio" tabindex="0"
...@@ -199,7 +199,7 @@ ...@@ -199,7 +199,7 @@
<div class="menu"> <div class="menu">
<div class="menu-header circle"> <div class="menu-header circle">
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div role="menu" i18n-content="timer_duration_button"></div> <div i18n-content="timer_duration_button"></div>
</div> </div>
<label class="menu-item circle" for="timer-3s"> <label class="menu-item circle" for="timer-3s">
<input class="icon" id="timer-3s" type="radio" tabindex="0" <input class="icon" id="timer-3s" type="radio" tabindex="0"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment