<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode

https://bugs.webkit.org/show_bug.cgi?id=57169

Reviewed by Maciej Stachowiak.

Source/WebCore: 

Test: fast/blockflow/fallback-orientation.html

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.

LayoutTests: 

* fast/blockflow/fallback-orientation.html: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@82056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/ChangeLog

+2011-03-26  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        <rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
+        https://bugs.webkit.org/show_bug.cgi?id=57169
+
+        * fast/blockflow/fallback-orientation.html: Added.
+        * platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
+        * platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
+        * platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.
+
 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin Adler.

third_party/WebKit/LayoutTests/fast/blockflow/fallback-orientation.html

+<p>
+    This should be pointing upwards:
+</p>
+<div style="font-family: 'hiragino mincho pro'; font-size: 80px; -webkit-writing-mode: vertical-rl;">
+    &#x3008;
+</div>
+</html>

third_party/WebKit/LayoutTests/platform/mac/fast/blockflow/fallback-orientation-expected.checksum

+7240cc2ea9f191173261de9bcdf00124
\ No newline at end of file

third_party/WebKit/LayoutTests/platform/mac/fast/blockflow/fallback-orientation-expected.txt

+layer at (0,0) size 785x650
+  RenderView at (0,0) size 785x600
+layer at (0,0) size 785x650
+  RenderBlock {HTML} at (0,0) size 785x650
+    RenderBody {BODY} at (8,8) size 769x634
+      RenderBlock {P} at (0,0) size 769x18
+        RenderText {#text} at (0,0) size 211x18
+          text run at (0,0) width 211: "This should be pointing upwards:"
+      RenderBlock {DIV} at (0,34) size 120x600
+        RenderText {#text} at (20,0) size 80x81
+          text run at (20,0) width 81: "\x{3008}"

third_party/WebKit/Source/WebCore/ChangeLog

+2011-03-26  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        <rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
+        https://bugs.webkit.org/show_bug.cgi?id=57169
+
+        Test: fast/blockflow/fallback-orientation.html
+
+        * platform/graphics/FontFastPath.cpp:
+        (WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
+        than continuing down the fallback list.
+
 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin Adler.

third_party/WebKit/Source/WebCore/platform/graphics/FontFastPath.cpp

@@ -96,7 +96,6 @@ GlyphData Font::glyphDataForCharacter(UChar32 c, bool mirror, FontDataVariant va
                             
                             // Shouldn't be possible to even reach this point.
                             ASSERT_NOT_REACHED();
-                            return data;
                         }
                     } else {
                         if (m_fontDescription.textOrientation() == TextOrientationVerticalRight) {
@@ -131,8 +130,8 @@ GlyphData Font::glyphDataForCharacter(UChar32 c, bool mirror, FontDataVariant va
 
                         // Shouldn't be possible to even reach this point.
                         ASSERT_NOT_REACHED();
-                        return data;
                     }
+                    return data;
                 }
 
                 if (node->isSystemFallback())