Commit af8f7390 authored by zhaoyangli's avatar zhaoyangli Committed by Commit Bot

[iOS] Ensure no ChromeIdentity class is compiled in EG2 tests.

This will prevent unnecessary dependencies from being pulled to EG2
tests.

Bug: 1015907

Change-Id: I45c5ec755761f1903b405542967c8a7321500ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929761Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718290}
parent 221e6458
...@@ -89,13 +89,15 @@ class TestMain { ...@@ -89,13 +89,15 @@ class TestMain {
DCHECK(!_testMain); DCHECK(!_testMain);
_testMain = std::make_unique<TestMain>(); _testMain = std::make_unique<TestMain>();
// Ensure that //ios/web and the bulk of //ios/chrome/browser are not compiled // Ensure that //ios/web, the bulk of //ios/chrome/browser and
// into the test module. This is hard to assert at compile time, due to // //ios/public/provider/chrome/browser/signin are not compiled into the test
// transitive dependencies, but at runtime it's easy to check if certain key // module. This is hard to assert at compile time, due to transitive
// classes are present or absent. // dependencies, but at runtime it's easy to check if certain key classes are
// present or absent.
CHECK(NSClassFromString(@"CRWWebController") == nil); CHECK(NSClassFromString(@"CRWWebController") == nil);
CHECK(NSClassFromString(@"MainController") == nil); CHECK(NSClassFromString(@"MainController") == nil);
CHECK(NSClassFromString(@"BrowserViewController") == nil); CHECK(NSClassFromString(@"BrowserViewController") == nil);
CHECK(NSClassFromString(@"ChromeIdentity") == nil);
} }
- (void)testBundleDidFinish:(NSBundle*)testBundle { - (void)testBundleDidFinish:(NSBundle*)testBundle {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment