Commit afa62a08 authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot

URLLoaderInterceptor: remove mention of fixed bug

The http://crbug.com/747130 is fixed, hence URLLoaderInterceptor should
work for frame requests - remove the obsolete comment. Also fix a typo
in a comment nearby. Seems like a typo to sincerely yours, non-native
speaker.

Bug: 747130
Change-Id: I7d88a09ce459d69348c3751fae845b5152324dff
Reviewed-on: https://chromium-review.googlesource.com/1104431Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568004}
parent 5abdd4b4
...@@ -26,7 +26,7 @@ class URLLoaderFactoryGetter; ...@@ -26,7 +26,7 @@ class URLLoaderFactoryGetter;
// of net::URLRequestFailedJob // of net::URLRequestFailedJob
// -requests by the browser // -requests by the browser
// //
// Prefer not to use this class. In order of easy of use & simplicity: // Prefer not to use this class. In order of ease of use & simplicity:
// -if you need to serve static data, use net::test::EmbeddedTestServer and // -if you need to serve static data, use net::test::EmbeddedTestServer and
// serve data from the source tree (e.g. in content/test/data) // serve data from the source tree (e.g. in content/test/data)
// -if you need to control the response data at runtime, then use // -if you need to control the response data at runtime, then use
...@@ -38,8 +38,6 @@ class URLLoaderFactoryGetter; ...@@ -38,8 +38,6 @@ class URLLoaderFactoryGetter;
// this helper class // this helper class
// //
// Notes: // Notes:
// -intercepting frame requests doesn't work yet for non network-service case
// (will work once http://crbug.com/747130 is fixed)
// -the callback is called on the UI or IO threads depending on the factory // -the callback is called on the UI or IO threads depending on the factory
// that was hooked // that was hooked
// -this is done to avoid changing message order // -this is done to avoid changing message order
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment