Commit afb604c4 authored by Xi Cheng's avatar Xi Cheng Committed by Commit Bot

Re-assign TODOs in time_formatting.h

Change-Id: I0ab76534d1afcf7e5b0faaf0629f3687e1e8ec45
Reviewed-on: https://chromium-review.googlesource.com/c/1347064
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610530}
parent b98f23d9
...@@ -106,8 +106,8 @@ BASE_I18N_EXPORT string16 TimeFormatWithPattern(const Time& time, ...@@ -106,8 +106,8 @@ BASE_I18N_EXPORT string16 TimeFormatWithPattern(const Time& time,
// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration // Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
// can possibly be larger than 24h, as the hour value will be cut below 24 // can possibly be larger than 24h, as the hour value will be cut below 24
// after formatting. // after formatting.
// TODO(chengx): fix function output when width = DURATION_WIDTH_NUMERIC // TODO(crbug.com/675791): fix function output when width =
// (http://crbug.com/675791) // DURATION_WIDTH_NUMERIC.
BASE_I18N_EXPORT bool TimeDurationFormat(const TimeDelta time, BASE_I18N_EXPORT bool TimeDurationFormat(const TimeDelta time,
const DurationFormatWidth width, const DurationFormatWidth width,
string16* out) WARN_UNUSED_RESULT; string16* out) WARN_UNUSED_RESULT;
...@@ -119,8 +119,8 @@ BASE_I18N_EXPORT bool TimeDurationFormat(const TimeDelta time, ...@@ -119,8 +119,8 @@ BASE_I18N_EXPORT bool TimeDurationFormat(const TimeDelta time,
// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration // Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
// can possibly be larger than 24h, as the hour value will be cut below 24 // can possibly be larger than 24h, as the hour value will be cut below 24
// after formatting. // after formatting.
// TODO(chengx): fix function output when width = DURATION_WIDTH_NUMERIC // TODO(crbug.com/675791): fix function output when width =
// (http://crbug.com/675791) // DURATION_WIDTH_NUMERIC.
BASE_I18N_EXPORT bool TimeDurationFormatWithSeconds( BASE_I18N_EXPORT bool TimeDurationFormatWithSeconds(
const TimeDelta time, const TimeDelta time,
const DurationFormatWidth width, const DurationFormatWidth width,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment