Commit afdfb291 authored by Ioana Pandele's avatar Ioana Pandele Committed by Commit Bot

Remove password export feature flag

This feature has been enabled for the past few stable releases, so the
flag is not needed anymore.

Bug: 838789, 792840
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib79921d30792dbd8e03fd2ec7652c15a76e84b73
Reviewed-on: https://chromium-review.googlesource.com/1203956Reviewed-by: default avatarVaclav Brozek <vabr@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589182}
parent b835d9c0
......@@ -51,10 +51,6 @@ const base::Feature kProtectSyncCredential = {
const base::Feature kProtectSyncCredentialOnReauth = {
"ProtectSyncCredentialOnReauth", base::FEATURE_DISABLED_BY_DEFAULT};
// Controls the ability to export passwords from Chrome's settings page.
const base::Feature kPasswordExport = {"PasswordExport",
base::FEATURE_ENABLED_BY_DEFAULT};
// Controls the ability to import passwords from Chrome's settings page.
const base::Feature kPasswordImport = {"PasswordImport",
base::FEATURE_DISABLED_BY_DEFAULT};
......
......@@ -28,7 +28,6 @@ extern const base::Feature kFillOnAccountSelect;
extern const base::Feature kMigrateLinuxToLoginDB;
extern const base::Feature kNewPasswordFormParsing;
extern const base::Feature kNewPasswordFormParsingForSaving;
extern const base::Feature kPasswordExport;
extern const base::Feature kPasswordImport;
extern const base::Feature kPasswordSearchMobile;
extern const base::Feature kPasswordsKeyboardAccessory;
......
......@@ -32,7 +32,6 @@
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/metrics_service.h"
#include "components/ntp_snippets/content_suggestions_service.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/passwords_directory_util_ios.h"
#include "components/payments/core/features.h"
#include "components/prefs/ios/pref_observer_bridge.h"
......@@ -1194,10 +1193,7 @@ enum class ShowTabSwitcherSnapshotResult {
[self sendQueuedFeedback];
[self scheduleSpotlightResync];
[self scheduleDeleteDownloadsDirectory];
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
[self scheduleDeleteTempPasswordsDirectory];
}
[self scheduleDeleteTempPasswordsDirectory];
[self scheduleStartupAttemptReset];
[self startFreeMemoryMonitoring];
[self scheduleAppDistributionPings];
......
......@@ -208,9 +208,6 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
{"memex-tab-switcher", flag_descriptions::kMemexTabSwitcherName,
flag_descriptions::kMemexTabSwitcherDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kMemexTabSwitcher)},
{"PasswordExport", flag_descriptions::kPasswordExportName,
flag_descriptions::kPasswordExportDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(password_manager::features::kPasswordExport)},
{"wk-http-system-cookie-store",
flag_descriptions::kWKHTTPSystemCookieStoreName,
flag_descriptions::kWKHTTPSystemCookieStoreName, flags_ui::kOsIos,
......
......@@ -209,10 +209,6 @@ const char kOutOfWebFullscreenDescription[] =
"Use the fullscreen implementation living outside of web. Disable the one "
"in web.";
const char kPasswordExportName[] = "Password Export";
const char kPasswordExportDescription[] =
"Enables password exporting functionality in password settings.";
const char kPhysicalWeb[] = "Physical Web";
const char kPhysicalWebDescription[] =
"When enabled, the omnibox will include suggestions for web pages "
......
......@@ -171,11 +171,6 @@ extern const char kOmniboxUIElideSuggestionUrlAfterHostDescription[];
extern const char kOutOfWebFullscreenName[];
extern const char kOutOfWebFullscreenDescription[];
// Title and description for the flag to enable the ability to export passwords
// from the password settings.
extern const char kPasswordExportName[];
extern const char kPasswordExportDescription[];
// Title and description for the flag to enable Physical Web in the omnibox.
extern const char kPhysicalWeb[];
extern const char kPhysicalWebDescription[];
......
......@@ -17,7 +17,6 @@
#include "components/keyed_service/core/service_access_type.h"
#include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_service.h"
#include "components/strings/grit/components_strings.h"
......@@ -1551,10 +1550,6 @@ PasswordForm CreateSampleFormWithIndex(int index) {
// Test export flow
- (void)testExportFlow {
if (!base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
return;
}
// Saving a form is needed for exporting passwords.
SaveExamplePasswordForm();
......
......@@ -21,7 +21,6 @@
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/password_ui_utils.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_member.h"
#include "components/prefs/pref_service.h"
......@@ -224,12 +223,9 @@ initWithActivityItems:(NSArray*)activityItems
browserState_ = browserState;
reauthenticationModule_ = [[ReauthenticationModule alloc]
initWithSuccessfulReauthTimeAccessor:self];
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
passwordExporter_ = [[PasswordExporter alloc]
initWithReauthenticationModule:reauthenticationModule_
delegate:self];
}
passwordExporter_ = [[PasswordExporter alloc]
initWithReauthenticationModule:reauthenticationModule_
delegate:self];
self.title = l10n_util::GetNSString(IDS_IOS_PASSWORDS);
self.collectionViewAccessibilityIdentifier =
@"SavePasswordsCollectionViewController";
......@@ -307,14 +303,11 @@ initWithActivityItems:(NSArray*)activityItems
forSectionWithIdentifier:SectionIdentifierBlacklist];
}
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
// Export passwords button.
[model addSectionWithIdentifier:SectionIdentifierExportPasswordsButton];
exportPasswordsItem_ = [self exportPasswordsItem];
[model addItem:exportPasswordsItem_
toSectionWithIdentifier:SectionIdentifierExportPasswordsButton];
}
// Export passwords button.
[model addSectionWithIdentifier:SectionIdentifierExportPasswordsButton];
exportPasswordsItem_ = [self exportPasswordsItem];
[model addItem:exportPasswordsItem_
toSectionWithIdentifier:SectionIdentifierExportPasswordsButton];
[self filterItems:self.searchTerm];
}
......@@ -606,8 +599,7 @@ blacklistedFormItemWithText:(NSString*)text
}
- (void)updateExportPasswordsButton {
if (!exportPasswordsItem_ || !base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport))
if (!exportPasswordsItem_)
return;
if (!savedForms_.empty() &&
self.passwordExporter.exportState == ExportState::IDLE) {
......@@ -733,8 +725,6 @@ blacklistedFormItemWithText:(NSString*)text
case ItemTypeExportPasswordsButton:
DCHECK_EQ(SectionIdentifierExportPasswordsButton,
[model sectionIdentifierForSection:indexPath.section]);
DCHECK(base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport));
if (exportReady_) {
[self startPasswordsExportFlow];
}
......@@ -759,10 +749,7 @@ blacklistedFormItemWithText:(NSString*)text
[super collectionViewWillBeginEditing:collectionView];
[self setSavePasswordsSwitchItemEnabled:NO];
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
[self setExportPasswordsButtonEnabled:NO];
}
[self setExportPasswordsButtonEnabled:NO];
[self setSearchPasswordsItemEnabled:NO];
}
......@@ -770,11 +757,8 @@ blacklistedFormItemWithText:(NSString*)text
[super collectionViewWillEndEditing:collectionView];
[self setSavePasswordsSwitchItemEnabled:YES];
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordExport)) {
if (exportReady_) {
[self setExportPasswordsButtonEnabled:YES];
}
if (exportReady_) {
[self setExportPasswordsButtonEnabled:YES];
}
[self setSearchPasswordsItemEnabled:YES];
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment