Commit afec5f40 authored by P H's avatar P H Committed by Commit Bot

Add UMA to report child supervision state transition results on ARC++.

Bug: 845224
Change-Id: I705d93fb547c434768747544ef09264923bbfb53
Reviewed-on: https://chromium-review.googlesource.com/1119411
Commit-Queue: Patricia Hongo <phongo@google.com>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarYury Khmel <khmel@chromium.org>
Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572063}
parent 4d1dec77
...@@ -107,6 +107,11 @@ void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state) { ...@@ -107,6 +107,11 @@ void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state) {
base::UmaHistogramSparse("Arc.OptInSilentAuthCode", static_cast<int>(state)); base::UmaHistogramSparse("Arc.OptInSilentAuthCode", static_cast<int>(state));
} }
void UpdateSupervisionTransitionResultUMA(
mojom::SupervisionChangeStatus result) {
UMA_HISTOGRAM_ENUMERATION("Arc.Supervision.Transition.Result", result);
}
void UpdateReauthorizationSilentAuthCodeUMA(OptInSilentAuthCode state) { void UpdateReauthorizationSilentAuthCodeUMA(OptInSilentAuthCode state) {
base::UmaHistogramSparse("Arc.OptInSilentAuthCode.Reauthorization", base::UmaHistogramSparse("Arc.OptInSilentAuthCode.Reauthorization",
static_cast<int>(state)); static_cast<int>(state));
......
...@@ -197,6 +197,8 @@ void UpdateReauthorizationResultUMA(ProvisioningResult result, ...@@ -197,6 +197,8 @@ void UpdateReauthorizationResultUMA(ProvisioningResult result,
void UpdatePlayStoreShowTime(const base::TimeDelta& elapsed_time, void UpdatePlayStoreShowTime(const base::TimeDelta& elapsed_time,
const Profile* profile); const Profile* profile);
void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state); void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state);
void UpdateSupervisionTransitionResultUMA(
mojom::SupervisionChangeStatus result);
void UpdateReauthorizationSilentAuthCodeUMA(OptInSilentAuthCode state); void UpdateReauthorizationSilentAuthCodeUMA(OptInSilentAuthCode state);
void UpdateAuthTiming(const char* histogram_name, base::TimeDelta elapsed_time); void UpdateAuthTiming(const char* histogram_name, base::TimeDelta elapsed_time);
void UpdateAuthCheckinAttempts(int32_t num_attempts); void UpdateAuthCheckinAttempts(int32_t num_attempts);
......
...@@ -209,6 +209,7 @@ void ArcAuthService::ReportAccountCheckStatus( ...@@ -209,6 +209,7 @@ void ArcAuthService::ReportAccountCheckStatus(
void ArcAuthService::ReportSupervisionChangeStatus( void ArcAuthService::ReportSupervisionChangeStatus(
mojom::SupervisionChangeStatus status) { mojom::SupervisionChangeStatus status) {
UpdateSupervisionTransitionResultUMA(status);
switch (status) { switch (status) {
case mojom::SupervisionChangeStatus::CLOUD_DPC_DISABLED: case mojom::SupervisionChangeStatus::CLOUD_DPC_DISABLED:
case mojom::SupervisionChangeStatus::CLOUD_DPC_ALREADY_DISABLED: case mojom::SupervisionChangeStatus::CLOUD_DPC_ALREADY_DISABLED:
......
...@@ -1621,6 +1621,21 @@ uploading your change for review. These are checked by presubmit scripts. ...@@ -1621,6 +1621,21 @@ uploading your change for review. These are checked by presubmit scripts.
<int value="21" label="Already provisioned"/> <int value="21" label="Already provisioned"/>
</enum> </enum>
<enum name="ArcSupervisionTransitionResult">
<summary>
Defines Arc supervision transition success and failure reasons
</summary>
<int value="0" label="CloudDPC supervision was disabled successfully."/>
<int value="1" label="CloudDPC supervision was already disabled."/>
<int value="2" label="CloudDPC supervision was enabled successfully."/>
<int value="3" label="CloudDPC supervision was already enabled."/>
<int value="4" label="Invalid state returned from Chrome."/>
<int value="5"
label="Failed to disable CloudDPC due to an unspecified error."/>
<int value="6"
label="Failed to enable CloudDPC due to an unspecified error."/>
</enum>
<enum name="ArcVideoDecodeAcceleratorResult"> <enum name="ArcVideoDecodeAcceleratorResult">
<summary>Defines ArcVideoDecodeAccelerator initialization status</summary> <summary>Defines ArcVideoDecodeAccelerator initialization status</summary>
<int value="0" label="SUCCESS"/> <int value="0" label="SUCCESS"/>
...@@ -3596,6 +3596,16 @@ uploading your change for review. ...@@ -3596,6 +3596,16 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="Arc.Supervision.Transition.Result"
enum="ArcSupervisionTransitionResult" expires_after="M71">
<owner>phongo@google.com</owner>
<owner>brunokim@google.com</owner>
<summary>
The result (success or the type of failure) of ARC supervision transition
events.
</summary>
</histogram>
<histogram name="ArcAuth.AccountCheckStatus" enum="ArcAuthAccountCheckStatus"> <histogram name="ArcAuth.AccountCheckStatus" enum="ArcAuthAccountCheckStatus">
<owner>elijahtaylor@google.com</owner> <owner>elijahtaylor@google.com</owner>
<summary>The status of account check before GMS Sign-in.</summary> <summary>The status of account check before GMS Sign-in.</summary>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment