Commit aff4dacf authored by Adam Langley's avatar Adam Langley Committed by Commit Bot

webauthn: use cached JNI classes.

The JNI wrapper code already caches the class objects. Use them in
DCHECKs rather than doing a lookup every time. Also means that typoing
the class name is now a compile-time failure.

BUG=1002262

Change-Id: Ifc86bdc859d6529d0aeaa54f99c63ad199a8b8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453919
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#814599}
parent 79309c78
...@@ -159,8 +159,8 @@ class AndroidBLEAdvert ...@@ -159,8 +159,8 @@ class AndroidBLEAdvert
: env_(env), advert_(std::move(advert)) { : env_(env), advert_(std::move(advert)) {
DCHECK(env_->IsInstanceOf( DCHECK(env_->IsInstanceOf(
advert_.obj(), advert_.obj(),
env_->FindClass( org_chromium_chrome_browser_webauth_authenticator_BLEAdvert_clazz(
"org/chromium/chrome/browser/webauth/authenticator/BLEAdvert"))); env)));
} }
~AndroidBLEAdvert() override { ~AndroidBLEAdvert() override {
...@@ -183,8 +183,8 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform { ...@@ -183,8 +183,8 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform {
: env_(env), cable_authenticator_(cable_authenticator) { : env_(env), cable_authenticator_(cable_authenticator) {
DCHECK(env_->IsInstanceOf( DCHECK(env_->IsInstanceOf(
cable_authenticator_.obj(), cable_authenticator_.obj(),
env_->FindClass("org/chromium/chrome/browser/webauth/authenticator/" org_chromium_chrome_browser_webauth_authenticator_CableAuthenticator_clazz(
"CableAuthenticator"))); env)));
} }
// Platform: // Platform:
...@@ -270,8 +270,8 @@ class USBTransport : public device::cablev2::authenticator::Transport { ...@@ -270,8 +270,8 @@ class USBTransport : public device::cablev2::authenticator::Transport {
: env_(env), usb_device_(std::move(usb_device)) { : env_(env), usb_device_(std::move(usb_device)) {
DCHECK(env_->IsInstanceOf( DCHECK(env_->IsInstanceOf(
usb_device_.obj(), usb_device_.obj(),
env_->FindClass( org_chromium_chrome_browser_webauth_authenticator_USBHandler_clazz(
"org/chromium/chrome/browser/webauth/authenticator/USBHandler"))); env)));
} }
~USBTransport() override { Java_USBHandler_close(env_, usb_device_); } ~USBTransport() override { Java_USBHandler_close(env_, usb_device_); }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment