Commit b042343a authored by Will Harris's avatar Will Harris Committed by Commit Bot

Remove calls to event log in GCP DllMain.

It is not safe to make these calls from DLLMain as they might
require the delay load resolver to execute within the loader
lock.

See https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-best-practices

"Recommendations: Verify that no calls depend on another DLL
that may not have been fully loaded yet."

BUG=1110400

Change-Id: I5f582d98a31065a31b90fac09e42b4dffa4302fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324494Reviewed-by: default avatarYusuf Sengul <yusufsn@google.com>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792442}
parent 145f1db1
......@@ -127,15 +127,6 @@ BOOL CGaiaCredentialProviderModule::DllMain(HINSTANCE /*hinstance*/,
logging::SetEventSource("GCPW", GCPW_CATEGORY, MSG_LOG_MESSAGE);
if (GetGlobalFlagOrDefault(kRegEnableVerboseLogging, 0))
logging::SetMinLogLevel(logging::LOG_VERBOSE);
wchar_t process_name[MAX_PATH] = {0};
GetModuleFileName(nullptr, process_name, MAX_PATH);
LOGFN(INFO) << "GCPW Initialized in " << process_name
<< " GCPW Version: " << (CHROME_VERSION_STRING)
<< " Windows Build: "
<< base::win::OSInfo::GetInstance()->Kernel32BaseVersion()
<< " Version:" << GetWindowsVersion();
break;
}
case DLL_PROCESS_DETACH:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment