Commit b0478950 authored by tommi@chromium.org's avatar tommi@chromium.org

Revert 288319 "Adding the VerifyModule function (and helpers) to..."

The tests were crashing on the windows bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%283%29/builds/29877/steps/unit_tests/logs/VerifyModuleModified):

SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (run #1):
[ RUN      ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(43): error: Value of: mem_dll_handle_.is_valid()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(48): error: Expected: (static_cast\u003CHMODULE>(0)) != (*mem_handle), actual: NULL vs NULL
Backtrace:
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0278AD98+6714120]
	(No symbol) [0x01761388]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02493F49+3605689]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024940CE+3606078]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024946AE+3607582]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024943E9+3606873]
	IsSandboxedProcess [0x0465F878+12316280]
	IsSandboxedProcess [0x0465F5AA+12315562]
	IsSandboxedProcess [0x04683A62+12464226]
	IsSandboxedProcess [0x045801B7+11401143]
	BaseThreadInitThunk [0x74C0338A+18]
	RtlInitializeExceptionChain [0x77299F72+99]
	RtlInitializeExceptionChain [0x77299F45+54]

> Adding the VerifyModule function (and helpers) to safe browsing.
> 
> This function allows us to compare a module in memory with 
> its original on disk, and identify any differences (after 
> accounting for relocations).  The state of the module 
> (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
> returned along with a list of the possibly modified exported 
> functions of the module.
> 
> 
> BUG=401854
> 
> Review URL: https://codereview.chromium.org/406043003

TBR=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/452133002

Cr-Commit-Position: refs/heads/master@{#288348}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288348 0039d316-1c4b-4281-b951-d872f2087c98
parent 0e58af80
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <windows.h>
extern "C" {
// Have a dummy export so that the module gets an export table entry.
void DummyExport() {
}
}
BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
return true;
}
; Copyright 2014 The Chromium Authors. All rights reserved.
; Use of this source code is governed by a BSD-style license that can be
; found in the LICENSE file.
LIBRARY "verifier_test_dll.dll"
EXPORTS
DummyExport
{
'targets': [
{
'target_name': 'verifier_test_dll',
'type': 'loadable_module',
'sources': [
'verifier_test_dll.cc',
'verifier_test_dll.def',
],
},
],
}
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment