Commit b050ee2d authored by Robbie McElrath's avatar Robbie McElrath Committed by Commit Bot

Re-enable VariationsHttpHeadersBrowserTest tests on ChromeOS.

I can't reproduce flakes locally, so I'm going to re-enable them and see
if we've fixed them in the last couple months. I also added additional
assertions to the test so we'll get more information about why they fail
if they do.

Bug: 964338
Change-Id: I4a864101de6cfb1b434c3b2157d2323d8e6e522a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693704Reviewed-by: default avatarEric Roman <eroman@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675871}
parent 88c0194a
......@@ -325,17 +325,9 @@ IN_PROC_BROWSER_TEST_F(VariationsHttpHeadersBrowserTest,
EXPECT_FALSE(HasReceivedHeader(GetExampleUrl(), "X-Client-Data"));
}
#if defined(OS_CHROMEOS)
// See https://crbug.com/964338
#define MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext \
DISABLED_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext
#else
#define MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext \
TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext
#endif
IN_PROC_BROWSER_TEST_F(
VariationsHttpHeadersBrowserTest,
MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext) {
TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext) {
GURL url = GetGoogleRedirectUrl1();
auto resource_request = std::make_unique<network::ResourceRequest>();
......@@ -356,6 +348,7 @@ IN_PROC_BROWSER_TEST_F(
// Wait for the response to complete.
loader_helper.WaitForCallback();
EXPECT_EQ(net::OK, loader->NetError());
EXPECT_TRUE(loader_helper.response_body());
EXPECT_TRUE(HasReceivedHeader(GetGoogleRedirectUrl1(), "X-Client-Data"));
......@@ -364,17 +357,9 @@ IN_PROC_BROWSER_TEST_F(
EXPECT_FALSE(HasReceivedHeader(GetExampleUrl(), "X-Client-Data"));
}
#if defined(OS_CHROMEOS)
// See https://crbug.com/964338
#define MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext \
DISABLED_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext
#else
#define MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext \
TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext
#endif
IN_PROC_BROWSER_TEST_F(
VariationsHttpHeadersBrowserTest,
MAYBE_TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext) {
TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext) {
GURL url = GetGoogleRedirectUrl1();
auto resource_request = std::make_unique<network::ResourceRequest>();
......@@ -395,6 +380,7 @@ IN_PROC_BROWSER_TEST_F(
// Wait for the response to complete.
loader_helper.WaitForCallback();
EXPECT_EQ(net::OK, loader->NetError());
EXPECT_TRUE(loader_helper.response_body());
EXPECT_TRUE(HasReceivedHeader(GetGoogleRedirectUrl1(), "X-Client-Data"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment